Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/isolate.cc

Issue 2748503002: [inspector] changed a way of preserving stepping between tasks (Closed)
Patch Set: rebased on tunned stepping at return Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/isolate.h" 5 #include "src/isolate.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include <fstream> // NOLINT(readability/streams) 9 #include <fstream> // NOLINT(readability/streams)
10 #include <sstream> 10 #include <sstream>
(...skipping 3303 matching lines...) Expand 10 before | Expand all | Expand 10 after
3314 void Isolate::FireCallCompletedCallback() { 3314 void Isolate::FireCallCompletedCallback() {
3315 if (!handle_scope_implementer()->CallDepthIsZero()) return; 3315 if (!handle_scope_implementer()->CallDepthIsZero()) return;
3316 3316
3317 bool run_microtasks = 3317 bool run_microtasks =
3318 pending_microtask_count() && 3318 pending_microtask_count() &&
3319 !handle_scope_implementer()->HasMicrotasksSuppressions() && 3319 !handle_scope_implementer()->HasMicrotasksSuppressions() &&
3320 handle_scope_implementer()->microtasks_policy() == 3320 handle_scope_implementer()->microtasks_policy() ==
3321 v8::MicrotasksPolicy::kAuto; 3321 v8::MicrotasksPolicy::kAuto;
3322 3322
3323 if (run_microtasks) RunMicrotasks(); 3323 if (run_microtasks) RunMicrotasks();
3324 // Prevent stepping from spilling into the next call made by the embedder.
3325 if (debug()->is_active()) debug()->ClearStepping();
3326 3324
3327 if (call_completed_callbacks_.is_empty()) return; 3325 if (call_completed_callbacks_.is_empty()) return;
3328 // Fire callbacks. Increase call depth to prevent recursive callbacks. 3326 // Fire callbacks. Increase call depth to prevent recursive callbacks.
3329 v8::Isolate* isolate = reinterpret_cast<v8::Isolate*>(this); 3327 v8::Isolate* isolate = reinterpret_cast<v8::Isolate*>(this);
3330 v8::Isolate::SuppressMicrotaskExecutionScope suppress(isolate); 3328 v8::Isolate::SuppressMicrotaskExecutionScope suppress(isolate);
3331 for (int i = 0; i < call_completed_callbacks_.length(); i++) { 3329 for (int i = 0; i < call_completed_callbacks_.length(); i++) {
3332 call_completed_callbacks_.at(i)(isolate); 3330 call_completed_callbacks_.at(i)(isolate);
3333 } 3331 }
3334 } 3332 }
3335 3333
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
3735 // Then check whether this scope intercepts. 3733 // Then check whether this scope intercepts.
3736 if ((flag & intercept_mask_)) { 3734 if ((flag & intercept_mask_)) {
3737 intercepted_flags_ |= flag; 3735 intercepted_flags_ |= flag;
3738 return true; 3736 return true;
3739 } 3737 }
3740 return false; 3738 return false;
3741 } 3739 }
3742 3740
3743 } // namespace internal 3741 } // namespace internal
3744 } // namespace v8 3742 } // namespace v8
OLDNEW
« no previous file with comments | « src/inspector/v8-runtime-agent-impl.cc ('k') | test/inspector/debugger/doesnt-step-into-injected-script.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698