Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: third_party/WebKit/Source/core/input/EventHandlerTest.cpp

Issue 2748483002: Making sure ClearHandleAfterTap's tap occurs inside of HTML document (Closed)
Patch Set: removed unnecessary div Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/EventHandlerTest.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandlerTest.cpp b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
index b6574da6b0c20d421688bfe0b21bc4551820cfbb..f8618151f6be13253f4f4efeefa617b8fe13d3b2 100644
--- a/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
@@ -368,10 +368,10 @@ TEST_F(EventHandlerTest, NonEmptyTextfieldInsertionOnLongPress) {
}
TEST_F(EventHandlerTest, ClearHandleAfterTap) {
- setHtmlInnerHTML("<textarea cols=50 rows=50>Enter text</textarea>");
+ setHtmlInnerHTML("<textarea cols=50 rows=10>Enter text</textarea>");
// Show handle
- LongPressEventBuilder longPressEvent(IntPoint(200, 200));
+ LongPressEventBuilder longPressEvent(IntPoint(200, 10));
document().frame()->eventHandler().handleGestureEvent(longPressEvent);
ASSERT_TRUE(
@@ -379,11 +379,9 @@ TEST_F(EventHandlerTest, ClearHandleAfterTap) {
ASSERT_TRUE(selection().isHandleVisible());
// Tap away from text area should clear handle
- TapEventBuilder singleTapEvent(IntPoint(700, 700), 1);
+ TapEventBuilder singleTapEvent(IntPoint(200, 350), 1);
document().frame()->eventHandler().handleGestureEvent(singleTapEvent);
- ASSERT_TRUE(
- selection().computeVisibleSelectionInDOMTreeDeprecated().isNone());
ASSERT_FALSE(selection().isHandleVisible());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698