Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: components/metrics/file_metrics_provider.h

Issue 2748463004: No 'prefs' state is necessary for an active file. (Closed)
Patch Set: fixed test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/file_metrics_provider.h
diff --git a/components/metrics/file_metrics_provider.h b/components/metrics/file_metrics_provider.h
index 080a8211dd2c0de10bc5c6d06ae6b94a6a462513..001fe837c2e752a857d2cff7d4c4acccbf14ce58 100644
--- a/components/metrics/file_metrics_provider.h
+++ b/components/metrics/file_metrics_provider.h
@@ -90,8 +90,9 @@ class FileMetricsProvider : public MetricsProvider,
// within that directory are used. Because some metadata may need to persist
// across process restarts, preferences entries are used based on the
// |prefs_key| name. Call RegisterPrefs() with the same name to create the
- // necessary keys in advance. Set |prefs_key| empty if no persistence is
- // required.
+ // necessary keys in advance. Set |prefs_key| empty (nullptr will work) if
+ // no persistence is required. ACTIVE files shouldn't have a pref key as
+ // they update internal state about what has been previously sent.
void RegisterSource(const base::FilePath& path,
SourceType type,
SourceAssociation source_association,
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | components/metrics/file_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698