Generalize the HIT_TEST accessibility action so that it can send any event.

ui/accessibility/ax_action_data.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/accessibility/ax_action_data.h"
 
 #include <set>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 
 using base::IntToString;
 
 namespace ui {
 
 AXActionData::AXActionData()
     : action(AX_ACTION_NONE),
       target_node_id(-1),
       flags(0),
       anchor_node_id(-1),
       anchor_offset(-1),
       focus_node_id(-1),
-      focus_offset(-1) {
-}
+      focus_offset(-1),
+      hit_test_event_to_fire(AX_EVENT_NONE) {}

[David Tseng, 2017/03/13 21:43:47]

Seems like this should default to hover. Alternatively, CHECK if HIT_TEST gets
called without an event to fire set.

[dmazzoni, 2017/03/20 05:40:40]

I added a DCHECK. I'd rather we make it explicit.

 
 AXActionData::AXActionData(const AXActionData& other) = default;
 
 AXActionData::~AXActionData() {
 }
 
 // Note that this includes an initial space character if nonempty, but
 // that works fine because this is normally printed by AXAction::ToString.
 std::string AXActionData::ToString() const {
   std::string result = ui::ToString(action);
@@ skipping 13 matching lines @@
   }
   if (focus_node_id != -1) {
     result += " focus_node_id=" + IntToString(focus_node_id);
     result += " focus_offset=" + IntToString(focus_offset);
   }
 
   return result;
 }
 
 }  // namespace ui