Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2748463002: Split header modification out of willSendRequest

Created:
3 years, 9 months ago by hiroshige
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, caseq+blink_chromium.org, loading-reviews_chromium.org, Yoav Weiss, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, tyoshino+watch_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split header modification out of willSendRequest BUG=632580

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : bug fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -54 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-memory-cached-resource.html View 2 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 4 chunks +15 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 2 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchContext.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 1 2 4 chunks +10 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (12 generated)
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-10 19:33:05 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748463002/1
3 years, 9 months ago (2017-03-10 19:33:42 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-10 19:37:59 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/248253) ios-device on ...
3 years, 9 months ago (2017-03-10 19:37:59 UTC) #4
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-10 23:40:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748463002/20001
3 years, 9 months ago (2017-03-10 23:41:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-11 01:20:41 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/399010)
3 years, 9 months ago (2017-03-11 01:20:42 UTC) #8
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-11 01:46:36 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748463002/40001
3 years, 9 months ago (2017-03-11 01:46:56 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-11 04:39:12 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 04:39:13 UTC) #12 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698