Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2748423002: changelog updates (Closed)

Created:
3 years, 9 months ago by kevmoo
Modified:
3 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

changelog updates Missing pub items for 36635d3c057c01791748d21124b72f43da89ef64 and other cleanup R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/72805979f32ee174c155fbbab2b9d2bebf433732

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M CHANGELOG.md View 1 3 chunks +44 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kevmoo
3 years, 9 months ago (2017-03-15 23:40:10 UTC) #3
kevmoo
3 years, 9 months ago (2017-03-15 23:40:10 UTC) #4
kevmoo
3 years, 9 months ago (2017-03-15 23:40:10 UTC) #5
Bob Nystrom
What about the telemetry stuff? https://codereview.chromium.org/2748423002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2748423002/diff/1/CHANGELOG.md#newcode52 CHANGELOG.md:52: `test/` or `tool/`. What ...
3 years, 9 months ago (2017-03-16 17:59:13 UTC) #6
kevmoo
I'll do another CL for telemetry https://codereview.chromium.org/2748423002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2748423002/diff/1/CHANGELOG.md#newcode52 CHANGELOG.md:52: `test/` or `tool/`. ...
3 years, 9 months ago (2017-03-17 20:11:02 UTC) #7
Bob Nystrom
lgtm
3 years, 9 months ago (2017-03-17 20:27:43 UTC) #8
kevmoo
3 years, 9 months ago (2017-03-17 20:39:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
72805979f32ee174c155fbbab2b9d2bebf433732 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698