Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: runtime/observatory/lib/src/elements/code_ref.dart

Issue 2748403002: Added page to Observatory to display native memory allocation information. (Closed)
Patch Set: Final patch. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/code_ref.dart
diff --git a/runtime/observatory/lib/src/elements/code_ref.dart b/runtime/observatory/lib/src/elements/code_ref.dart
index 14b783bd92c47eb3d555f78b3c0817ab2a8184ee..f262cf442e48ec59778aeecebd1053168df8a28d 100644
--- a/runtime/observatory/lib/src/elements/code_ref.dart
+++ b/runtime/observatory/lib/src/elements/code_ref.dart
@@ -27,7 +27,6 @@ class CodeRefElement extends HtmlElement implements Renderable {
factory CodeRefElement(M.IsolateRef isolate, M.CodeRef code,
{RenderingQueue queue}) {
- assert(isolate != null);
assert(code != null);
CodeRefElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
@@ -55,7 +54,7 @@ class CodeRefElement extends HtmlElement implements Renderable {
final name = (_code.isOptimized ? '*' : '') + _code.name;
children = [
new AnchorElement(
- href: M.isSyntheticCode(_code.kind)
+ href: ((M.isSyntheticCode(_code.kind)) || (_isolate == null))
? null
: Uris.inspect(_isolate, object: _code))..text = name
];

Powered by Google App Engine
This is Rietveld 408576698