Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2748393003: Add trace events in NavigationControllerImpl::back/forward(...). (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 7e04526e5894a53823c197cb54cff0163ebfacc4..cc647ac174045066482b9189a272aeaa487a86da 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -587,11 +587,15 @@ bool NavigationControllerImpl::CanGoToOffset(int offset) const {
void NavigationControllerImpl::GoBack() {
// Call GoToIndex rather than GoToOffset to get the NOTREACHED() check.
tdresser 2017/03/16 12:24:38 Move the comment below the trace event, it's refer
sunjian 2017/03/16 18:40:30 Acknowledged.
+ TRACE_EVENT0("browser,navigation",
+ "NavigationControllerImpl::GoBack");
GoToIndex(GetIndexForOffset(-1));
}
void NavigationControllerImpl::GoForward() {
// Call GoToIndex rather than GoToOffset to get the NOTREACHED() check.
+ TRACE_EVENT0("browser,navigation",
+ "NavigationControllerImpl::GoForward");
GoToIndex(GetIndexForOffset(1));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698