Add trace events in NavigationControllerImpl::back/forward(...).

content/browser/frame_host/navigation_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  *     (http://www.torchmobile.com/)
  *
@@ skipping 568 matching lines @@
 bool NavigationControllerImpl::CanGoForward() const {
   return CanGoToOffset(1);
 }
 
 bool NavigationControllerImpl::CanGoToOffset(int offset) const {
   int index = GetIndexForOffset(offset);
   return index >= 0 && index < GetEntryCount();
 }
 
 void NavigationControllerImpl::GoBack() {
+  TRACE_EVENT0("browser,navigation",
+               "NavigationControllerImpl::GoBack");
   // Call GoToIndex rather than GoToOffset to get the NOTREACHED() check.
   GoToIndex(GetIndexForOffset(-1));
 }
 
 void NavigationControllerImpl::GoForward() {
+  TRACE_EVENT0("browser,navigation",
+               "NavigationControllerImpl::GoForward");
   // Call GoToIndex rather than GoToOffset to get the NOTREACHED() check.
   GoToIndex(GetIndexForOffset(1));
 }
 
 void NavigationControllerImpl::GoToIndex(int index) {
   if (index < 0 || index >= static_cast<int>(entries_.size())) {
     NOTREACHED();
     return;
   }
 
@@ skipping 11 matching lines @@
   DiscardNonCommittedEntries();
 
   pending_entry_index_ = index;
   entries_[pending_entry_index_]->SetTransitionType(
       ui::PageTransitionFromInt(
           entries_[pending_entry_index_]->GetTransitionType() |
           ui::PAGE_TRANSITION_FORWARD_BACK));
   NavigateToPendingEntry(ReloadType::NONE);
 }
 
 void NavigationControllerImpl::GoToOffset(int offset) {

[nasko, 2017/03/16 20:34:44]

Might be useful to add tracing to this one and GoToIndex, to cover other cases
you might not have seen yet.

[tdresser, 2017/03/17 13:31:44]

If we only instrumented GoToIndex, we'd have full coverage here.
I'd be in favor of switching to only tracing in GoToIndex.

   // Note: This is actually reached in unit tests.
   if (!CanGoToOffset(offset))
     return;
 
   GoToIndex(GetIndexForOffset(offset));
 }
 
 bool NavigationControllerImpl::RemoveEntryAtIndex(int index) {
   if (index == last_committed_entry_index_ ||
       index == pending_entry_index_)
@@ skipping 1516 matching lines @@
     }
   }
 }
 
 void NavigationControllerImpl::SetGetTimestampCallbackForTest(
     const base::Callback<base::Time()>& get_timestamp_callback) {
   get_timestamp_callback_ = get_timestamp_callback;
 }
 
 }  // namespace content