Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2748383003: Split MirrorsAnalysis (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split MirrorsAnalysis - into MirrorsResolutionAnalysis(Impl), MirrorsCodegenAnalysis(Impl) R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/65b06efb586800d91b089241ae332a58b93c7f7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -101 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 10 chunks +30 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 4 chunks +140 lines, -79 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirror_tree_shaking_test.dart View 2 chunks +12 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-16 14:07:34 UTC) #2
Johnni Winther
ping
3 years, 9 months ago (2017-03-17 08:50:11 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 9 months ago (2017-03-17 22:02:16 UTC) #4
Johnni Winther
3 years, 9 months ago (2017-03-27 09:34:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
65b06efb586800d91b089241ae332a58b93c7f7b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698