Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: chrome/browser/ui/views/harmony/layout_delegate.cc

Issue 2748363002: Fix UBSan testing builds (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/chrome_views_delegate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/harmony/layout_delegate.h" 5 #include "chrome/browser/ui/views/harmony/layout_delegate.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chrome/browser/ui/views/chrome_views_delegate.h" 9 #include "chrome/browser/ui/views/chrome_views_delegate.h"
10 #include "chrome/browser/ui/views/harmony/harmony_layout_delegate.h" 10 #include "chrome/browser/ui/views/harmony/harmony_layout_delegate.h"
11 #include "ui/base/material_design/material_design_controller.h" 11 #include "ui/base/material_design/material_design_controller.h"
12 #include "ui/views/layout/layout_constants.h" 12 #include "ui/views/layout/layout_constants.h"
13 13
14 static base::LazyInstance<LayoutDelegate>::DestructorAtExit layout_delegate_ = 14 static base::LazyInstance<LayoutDelegate>::DestructorAtExit layout_delegate_ =
15 LAZY_INSTANCE_INITIALIZER; 15 LAZY_INSTANCE_INITIALIZER;
16 16
17 // static 17 // static
18 LayoutDelegate* LayoutDelegate::Get() { 18 LayoutDelegate* LayoutDelegate::Get() {
19 return ui::MaterialDesignController::IsSecondaryUiMaterial() 19 return ui::MaterialDesignController::IsSecondaryUiMaterial()
20 ? HarmonyLayoutDelegate::Get() 20 ? HarmonyLayoutDelegate::Get()
21 : layout_delegate_.Pointer(); 21 : layout_delegate_.Pointer();
22 } 22 }
23 23
24 int LayoutDelegate::GetMetric(Metric metric) const { 24 int LayoutDelegate::GetMetric(Metric metric) const {
25 switch (metric) { 25 switch (metric) {
26 case Metric::BUTTON_HORIZONTAL_PADDING: 26 case Metric::BUTTON_HORIZONTAL_PADDING:
27 return ChromeViewsDelegate::GetInstance()->GetDefaultDistanceMetric( 27 return ChromeViewsDelegate::GetDefaultDistanceMetric(
28 views::DistanceMetric::BUTTON_HORIZONTAL_PADDING); 28 views::DistanceMetric::BUTTON_HORIZONTAL_PADDING);
29 case Metric::BUTTON_MAX_LINKABLE_WIDTH: 29 case Metric::BUTTON_MAX_LINKABLE_WIDTH:
30 return 0; // Buttons never expand during layout (add padding instead). 30 return 0; // Buttons never expand during layout (add padding instead).
31 case Metric::BUTTON_MINIMUM_WIDTH: 31 case Metric::BUTTON_MINIMUM_WIDTH:
32 return views::kMinimumButtonWidth; 32 return views::kMinimumButtonWidth;
33 case Metric::DIALOG_BUTTON_MARGIN: 33 case Metric::DIALOG_BUTTON_MARGIN:
34 return views::kButtonHEdgeMarginNew; 34 return views::kButtonHEdgeMarginNew;
35 case Metric::DIALOG_BUTTON_MINIMUM_WIDTH: 35 case Metric::DIALOG_BUTTON_MINIMUM_WIDTH:
36 return ChromeViewsDelegate::GetInstance()->GetDefaultDistanceMetric( 36 return ChromeViewsDelegate::GetDefaultDistanceMetric(
37 views::DistanceMetric::DIALOG_BUTTON_MINIMUM_WIDTH); 37 views::DistanceMetric::DIALOG_BUTTON_MINIMUM_WIDTH);
38 case Metric::DIALOG_BUTTON_TOP_SPACING: 38 case Metric::DIALOG_BUTTON_TOP_SPACING:
39 return 0; 39 return 0;
40 case Metric::DIALOG_CLOSE_BUTTON_MARGIN: 40 case Metric::DIALOG_CLOSE_BUTTON_MARGIN:
41 return ChromeViewsDelegate::GetInstance()->GetDefaultDistanceMetric( 41 return ChromeViewsDelegate::GetDefaultDistanceMetric(
42 views::DistanceMetric::CLOSE_BUTTON_MARGIN); 42 views::DistanceMetric::CLOSE_BUTTON_MARGIN);
43 case Metric::PANEL_CONTENT_MARGIN: 43 case Metric::PANEL_CONTENT_MARGIN:
44 return views::kPanelHorizMargin; 44 return views::kPanelHorizMargin;
45 case Metric::RELATED_BUTTON_HORIZONTAL_SPACING: 45 case Metric::RELATED_BUTTON_HORIZONTAL_SPACING:
46 return ChromeViewsDelegate::GetInstance()->GetDefaultDistanceMetric( 46 return ChromeViewsDelegate::GetDefaultDistanceMetric(
47 views::DistanceMetric::RELATED_BUTTON_HORIZONTAL); 47 views::DistanceMetric::RELATED_BUTTON_HORIZONTAL);
48 case Metric::RELATED_CONTROL_HORIZONTAL_SPACING: 48 case Metric::RELATED_CONTROL_HORIZONTAL_SPACING:
49 return ChromeViewsDelegate::GetInstance()->GetDefaultDistanceMetric( 49 return ChromeViewsDelegate::GetDefaultDistanceMetric(
50 views::DistanceMetric::RELATED_CONTROL_HORIZONTAL); 50 views::DistanceMetric::RELATED_CONTROL_HORIZONTAL);
51 case Metric::RELATED_CONTROL_VERTICAL_SPACING: 51 case Metric::RELATED_CONTROL_VERTICAL_SPACING:
52 return ChromeViewsDelegate::GetInstance()->GetDefaultDistanceMetric( 52 return ChromeViewsDelegate::GetDefaultDistanceMetric(
53 views::DistanceMetric::RELATED_CONTROL_VERTICAL); 53 views::DistanceMetric::RELATED_CONTROL_VERTICAL);
54 case Metric::RELATED_LABEL_HORIZONTAL_SPACING: 54 case Metric::RELATED_LABEL_HORIZONTAL_SPACING:
55 return views::kItemLabelSpacing; 55 return views::kItemLabelSpacing;
56 case Metric::SUBSECTION_HORIZONTAL_INDENT: 56 case Metric::SUBSECTION_HORIZONTAL_INDENT:
57 return views::kCheckboxIndent; 57 return views::kCheckboxIndent;
58 case Metric::UNRELATED_CONTROL_HORIZONTAL_SPACING: 58 case Metric::UNRELATED_CONTROL_HORIZONTAL_SPACING:
59 return views::kUnrelatedControlHorizontalSpacing; 59 return views::kUnrelatedControlHorizontalSpacing;
60 case Metric::UNRELATED_CONTROL_HORIZONTAL_SPACING_LARGE: 60 case Metric::UNRELATED_CONTROL_HORIZONTAL_SPACING_LARGE:
61 return views::kUnrelatedControlLargeHorizontalSpacing; 61 return views::kUnrelatedControlLargeHorizontalSpacing;
62 case Metric::UNRELATED_CONTROL_VERTICAL_SPACING: 62 case Metric::UNRELATED_CONTROL_VERTICAL_SPACING:
(...skipping 14 matching lines...) Expand all
77 return true; 77 return true;
78 } 78 }
79 79
80 bool LayoutDelegate::IsHarmonyMode() const { 80 bool LayoutDelegate::IsHarmonyMode() const {
81 return false; 81 return false;
82 } 82 }
83 83
84 int LayoutDelegate::GetDialogPreferredWidth(DialogWidth width) const { 84 int LayoutDelegate::GetDialogPreferredWidth(DialogWidth width) const {
85 return 0; 85 return 0;
86 } 86 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/chrome_views_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698