Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/chromeos/printing/cups_print_job.h

Issue 2748253005: Cleanup jobs which have failed. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/printing/cups_print_job.h
diff --git a/chrome/browser/chromeos/printing/cups_print_job.h b/chrome/browser/chromeos/printing/cups_print_job.h
index 09be00de135cafd0b8c5b4af56c3f69af14efcf1..997989fa715f167634415e6e6534651bd33a3751 100644
--- a/chrome/browser/chromeos/printing/cups_print_job.h
+++ b/chrome/browser/chromeos/printing/cups_print_job.h
@@ -52,6 +52,7 @@ class CupsPrintJob {
const std::string& document_title() const { return document_title_; }
int total_page_number() const { return total_page_number_; }
int printed_page_number() const { return printed_page_number_; }
+ bool expired() const { return expired_; }
State state() const { return state_; }
ErrorCode error_code() const { return error_code_; }
@@ -59,6 +60,7 @@ class CupsPrintJob {
void set_printed_page_number(int page_number) {
printed_page_number_ = page_number;
}
+ void set_expired(bool expired) { expired_ = expired; }
void set_state(State state) { state_ = state; }
void set_error_code(ErrorCode error_code) { error_code_ = error_code; }
@@ -73,6 +75,9 @@ class CupsPrintJob {
int total_page_number_ = 0;
int printed_page_number_ = 0;
+ // True if the job has expired due to timeout.
+ bool expired_ = false;
xdai1 2017/03/16 19:56:16 Maybe we can merge this variable to ErrorCode?
skau 2017/03/16 22:14:36 We could. But I think it'll be easier to maintain
xdai1 2017/03/16 22:56:14 Acknowledged.
+
State state_ = State::STATE_NONE;
ErrorCode error_code_ = ErrorCode::NO_ERROR;

Powered by Google App Engine
This is Rietveld 408576698