Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 2748213003: Service Worker event dispatcher for Background Fetch (Closed)
Patch Set: uma fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index a9a5e91de3a10ca63e2537969fe053c3eaae1003..c64657e65c755151a2e21de6866abbb3c830d161 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -82,6 +82,10 @@ std::string EventTypeToSuffix(ServiceWorkerMetrics::EventType event_type) {
return "_EXTERNAL_REQUEST";
case ServiceWorkerMetrics::EventType::PAYMENT_REQUEST:
return "_PAYMENT_REQUEST";
+ case ServiceWorkerMetrics::EventType::BACKGROUND_FETCH_ABORT:
+ return "_BACKGROUND_FETCH_ABORT";
+ case ServiceWorkerMetrics::EventType::BACKGROUND_FETCH_CLICK:
+ return "_BACKGROUND_FETCH_CLICK";
case ServiceWorkerMetrics::EventType::NUM_TYPES:
NOTREACHED() << static_cast<int>(event_type);
}
@@ -357,6 +361,10 @@ const char* ServiceWorkerMetrics::EventTypeToString(EventType event_type) {
return "External Request";
case EventType::PAYMENT_REQUEST:
return "Payment Request";
+ case EventType::BACKGROUND_FETCH_ABORT:
+ return "Background Fetch Abort";
+ case EventType::BACKGROUND_FETCH_CLICK:
+ return "Background Fetch Click";
case EventType::NUM_TYPES:
break;
}
@@ -687,6 +695,14 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event,
UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.PaymentRequestEvent.Time",
time);
break;
+ case EventType::BACKGROUND_FETCH_ABORT:
+ UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.BackgroundFetchAbortEvent.Time",
+ time);
+ break;
+ case EventType::BACKGROUND_FETCH_CLICK:
+ UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.BackgroundFetchClickEvent.Time",
+ time);
+ break;
// Those navigation hints should not be sent as request events.
case EventType::NAVIGATION_HINT_LINK_MOUSE_DOWN:
case EventType::NAVIGATION_HINT_LINK_TAP_UNCONFIRMED:

Powered by Google App Engine
This is Rietveld 408576698