tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index a87eb33938db90235b8adecd1ae5bfbe5729a049..47efbd1fc5334d4d72d27cd7c8e3f1c36c3466a3 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -4144,6 +4144,51 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="BackgroundFetch.EventDispatchFailure.Dispatch"
+    enum="ServiceWorkerStatusCode">
+<!-- Name completed by histogram_suffixes name="BackgroundFetchEvents" -->

[Ilya Sherman, 2017/03/16 03:58:50]

This comment makes me think that you probably want to add base="true" to the
<histogram> element.

[Peter Beverloo, 2017/03/16 16:05:58]

Done.

+
+  <owner>peter@chromium.org</owner>
+  <summary>
+    Records the Service Worker status code that caused an Background Fetch API

[Ilya Sherman, 2017/03/16 03:58:50]

nit: s/an/a

[Peter Beverloo, 2017/03/16 16:05:58]

Done. Elsewhere too.

+    event to fail dispatching whilst trying to dispatch an event on the active
+    Service Worker.
+  </summary>
+</histogram>
+
+<histogram name="BackgroundFetch.EventDispatchFailure.FindWorker"
+    enum="ServiceWorkerStatusCode">
+<!-- Name completed by histogram_suffixes name="BackgroundFetchEvents" -->
+
+  <owner>peter@chromium.org</owner>
+  <summary>
+    Records the Service Worker status code that caused an Background Fetch API
+    event to fail dispatching whilst trying to find the Service Worker.
+  </summary>
+</histogram>
+
+<histogram name="BackgroundFetch.EventDispatchFailure.StartWorker"
+    enum="ServiceWorkerStatusCode">
+<!-- Name completed by histogram_suffixes name="BackgroundFetchEvents" -->
+
+  <owner>peter@chromium.org</owner>
+  <summary>
+    Records the Service Worker status code that caused an Background Fetch API
+    event to fail dispatching whilst trying to start the active Service Worker.
+  </summary>
+</histogram>
+
+<histogram name="BackgroundFetch.EventDispatchResult"
+    enum="BackgroundFetchEventDispatchResult">
+<!-- Name completed by histogram_suffixes name="BackgroundFetchEvents" -->
+
+  <owner>peter@chromium.org</owner>
+  <summary>
+    Records the result of dispatching one of the Background Fetch API events to
+    the Service Worker associated with the event.
+  </summary>
+</histogram>
+
 <histogram name="BackgroundMode.BackgroundApplicationsCount">
   <owner>atwilson@chromium.org</owner>
   <owner>mvanouwerkerk@chromium.org</owner>
@@ -62464,6 +62509,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="ServiceWorker.BackgroundFetchAbortEvent.Time" units="ms">
+  <owner>peter@chromium.org</owner>
+  <summary>
+    The time taken between dispatching a BackgroundFetchAbortEvent to a Service
+    Worker and receiving a message that it finished handling the event. Includes
+    the time for the waitUntil() promise to settle.
+  </summary>
+</histogram>
+
+<histogram name="ServiceWorker.BackgroundFetchClickEvent.Time" units="ms">
+  <owner>peter@chromium.org</owner>
+  <summary>
+    The time taken between dispatching a BackgroundFetchClickEvent to a Service
+    Worker and receiving a message that it finished handling the event. Includes
+    the time for the waitUntil() promise to settle.
+  </summary>
+</histogram>
+
 <histogram name="ServiceWorker.BackgroundSyncEvent.Time" units="ms">
   <owner>jkarlin@chromium.org</owner>
   <summary>
@@ -81927,6 +81990,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="2" label="Ok, got it"/>
 </enum>
 
+<enum name="BackgroundFetchEventDispatchResult" type="int">
+  <int value="0" label="Success"/>
+  <int value="1" label="Cannot find the Service Worker registration"/>
+  <int value="2" label="Cannot start the active Service Worker"/>
+  <int value="3" label="Cannot dispatch the event on the Service Worker"/>

[Ilya Sherman, 2017/03/16 03:58:50]

Optional: I'd recommend using shorter labels for a more readable dashboard
display, perhaps with hovertext to provide more detail if need be
, e.g.

<int value="3" label="Cannot dispatch event">Cannot dispatch the event on the
Service Worker</int>

[Peter Beverloo, 2017/03/16 16:05:58]

Ack. Removed additional text, it's still clear enough to not need the hover
text. That's a cool feature.

+</enum>
+
 <enum name="BackgroundFetchTrigger" type="int">
   <int value="0" label="Wake-up of the persistent scheduler"/>
   <int value="1" label="NTP opened"/>
@@ -108687,6 +108757,8 @@ from previous Chrome versions.
   <int value="20" label="NAVIGATION_HINT_LINK_TAP_DOWN"/>
   <int value="21" label="EXTERNAL_REQUEST"/>
   <int value="22" label="PAYMENT_REQUEST"/>
+  <int value="23" label="BACKGROUND_FETCH_ABORT"/>
+  <int value="24" label="BACKGROUND_FETCH_CLICK"/>
 </enum>
 
 <enum name="ServiceWorkerPreparationType" type="int">
@@ -114630,6 +114702,15 @@ from previous Chrome versions.
   <affected-histogram name="Autofill.UnmaskPrompt.Duration"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="BackgroundFetchEvents" separator=".">
+  <suffix name="AbortEvent"/>
+  <suffix name="ClickEvent"/>

[Ilya Sherman, 2017/03/16 03:58:50]

nit: Please add a brief label for each suffix.

[Peter Beverloo, 2017/03/16 16:05:58]

Done.

+  <affected-histogram name="BackgroundFetch.EventDispatchFailure.Dispatch"/>
+  <affected-histogram name="BackgroundFetch.EventDispatchFailure.FindWorker"/>
+  <affected-histogram name="BackgroundFetch.EventDispatchFailure.StartWorker"/>
+  <affected-histogram name="BackgroundFetch.EventDispatchResult"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="BadBlockCounts" separator=".">
   <suffix name="Backupsys" label="backupsys partition"/>
   <suffix name="Bbt" label="bbt partition"/>