Issue 2748133002: Fix DDC status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2748133002: Fix DDC status (Closed)

Created:
3 years, 9 months ago by vsm

Modified:
3 years, 9 months ago

Reviewers:
sra1

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix DDC status These tests appear to pass on FF, but fail on Chrome. TBR=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/9c1a75bf34da7eae65286e467fe26b528d76835c

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	pkg/dev_compiler/test/browser/language_tests.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

Committed patchset #1 (id:1) manually as 9c1a75bf34da7eae65286e467fe26b528d76835c (presubmit successful).

3 years, 9 months ago (2017-03-14 14:29:05 UTC) #2

vsm

3 years, 9 months ago (2017-03-14 14:31:41 UTC) #3

Message was sent while issue was closed.

On 2017/03/14 14:29:05, vsm wrote:
> Committed patchset #1 (id:1) manually as
> 9c1a75bf34da7eae65286e467fe26b528d76835c (presubmit successful).

Actually, they are failing on Chrome 57, but passing on 59.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages