third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp

index 507b19f5b8ea295006eee06437b5aadbd0525b44..ca6b47a6d08f83bc57b8858c857fcd96f75de035 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp

@@ -44,7 +44,7 @@ void LayoutSVGRect::updateShapeFromElement() {

m_strokeBoundingBox = FloatRect();

m_usePathFallback = false;

SVGRectElement* rect = toSVGRectElement(element());

- ASSERT(rect);

+ DCHECK(rect);

SVGLengthContext lengthContext(rect);

FloatSize boundingBoxSize(