third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGEllipse.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

index 99ff2eb287621923159474a0993008f507c623a5..d4adbd1533cd0040706e49a65c7718b3d569057c 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

@@ -94,7 +94,7 @@ void LayoutSVGForeignObject::computeLogicalHeight(

}

void LayoutSVGForeignObject::layout() {

- ASSERT(needsLayout());

+ DCHECK(needsLayout());

SVGForeignObjectElement* foreign = toSVGForeignObjectElement(node());

@@ -118,7 +118,7 @@ void LayoutSVGForeignObject::layout() {

bool layoutChanged = everHadLayout() && selfNeedsLayout();

LayoutBlock::layout();

- ASSERT(!needsLayout());

+ DCHECK(!needsLayout());

// If our bounds changed, notify the parents.

if (!updateCachedBoundariesInParents)