third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h

diff --git a/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h b/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h

index 6008e28bef195d39f187a940afbf155e3df7ccd4..1a7b77f23fcfbeb341ab49f3b6c80a47ab58c5dd 100644

--- a/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h

+++ b/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h

@@ -68,15 +68,15 @@ class ShapeOutsideDeltas final {

bool isValid() { return m_isValid; }

LayoutUnit leftMarginBoxDelta() {

- ASSERT(m_isValid);

+ DCHECK(m_isValid);

return m_leftMarginBoxDelta;

}

LayoutUnit rightMarginBoxDelta() {

- ASSERT(m_isValid);

+ DCHECK(m_isValid);

return m_rightMarginBoxDelta;

}

bool lineOverlapsShape() {

- ASSERT(m_isValid);

+ DCHECK(m_isValid);

return m_lineOverlapsShape;

}