third_party/WebKit/Source/core/layout/shapes/BoxShape.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/shapes/BoxShape.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/shapes/BoxShape.cpp

diff --git a/third_party/WebKit/Source/core/layout/shapes/BoxShape.cpp b/third_party/WebKit/Source/core/layout/shapes/BoxShape.cpp

index bac2b8633abf3047be7168d344cd066472678959..9936413c9586c04921046a683080517d489a1d98 100644

--- a/third_party/WebKit/Source/core/layout/shapes/BoxShape.cpp

+++ b/third_party/WebKit/Source/core/layout/shapes/BoxShape.cpp

@@ -96,7 +96,7 @@ LineSegment BoxShape::getExcludedInterval(LayoutUnit logicalTop,

x2 = std::max<float>(x2, maxXIntercept);

}

- ASSERT(x2 >= x1);

+ DCHECK_GE(x2, x1);

return LineSegment(x1, x2);

}