third_party/WebKit/Source/core/layout/line/InlineTextBox.h - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.h

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineTextBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineTextBox.h b/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

index a9bec87f38bb4bbef0117be63257d35ea41f3b1b..30aceba9ac01a100c89709258c4aa6a17a915cfb 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

@@ -71,7 +71,7 @@ class CORE_EXPORT InlineTextBox : public InlineBox {

void setNextTextBox(InlineTextBox* n) { m_nextTextBox = n; }

void setPreviousTextBox(InlineTextBox* p) { m_prevTextBox = p; }

- // FIXME: These accessors should ASSERT(!isDirty()). See

+ // FIXME: These accessors should DCHECK(!isDirty()). See

// https://bugs.webkit.org/show_bug.cgi?id=97264

unsigned start() const { return m_start; }

unsigned end() const { return m_len ? m_start + m_len - 1 : m_start; }