Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3138)

Unified Diff: chrome/browser/engagement/site_engagement_service.cc

Issue 2748103011: Grant origins engagement for having interactions on their notifications. (Closed)
Patch Set: Unfriend Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service.cc
diff --git a/chrome/browser/engagement/site_engagement_service.cc b/chrome/browser/engagement/site_engagement_service.cc
index edda88c4b38d468b73d20c7465cc203aec8c1342..9aebd1448dcd0afd8855021741f2e940f3c5ec67 100644
--- a/chrome/browser/engagement/site_engagement_service.cc
+++ b/chrome/browser/engagement/site_engagement_service.cc
@@ -155,6 +155,20 @@ std::map<GURL, double> SiteEngagementService::GetScoreMap() const {
return score_map;
}
+void SiteEngagementService::HandleNotificationInteraction(const GURL& url) {
+ if (!ShouldRecordEngagement(url))
+ return;
+
+ SiteEngagementMetrics::RecordEngagement(
+ SiteEngagementMetrics::ENGAGEMENT_NOTIFICATION_INTERACTION);
+ AddPoints(url, SiteEngagementScore::GetNotificationInteractionPoints());
+
+ RecordMetrics();
+ double score = GetScore(url);
+ for (SiteEngagementObserver& observer : observer_list_)
+ observer.OnEngagementIncreased(nullptr /* web_contents */, url, score);
+}
+
bool SiteEngagementService::IsBootstrapped() const {
return GetTotalEngagementPoints() >=
SiteEngagementScore::GetBootstrapPoints();
@@ -475,8 +489,9 @@ void SiteEngagementService::HandleMediaPlaying(
: SiteEngagementScore::GetVisibleMediaPoints());
RecordMetrics();
+ double score = GetScore(url);
for (SiteEngagementObserver& observer : observer_list_)
- observer.OnEngagementIncreased(web_contents, url, GetScore(url));
+ observer.OnEngagementIncreased(web_contents, url, score);
}
void SiteEngagementService::HandleNavigation(content::WebContents* web_contents,
@@ -490,8 +505,9 @@ void SiteEngagementService::HandleNavigation(content::WebContents* web_contents,
AddPoints(url, SiteEngagementScore::GetNavigationPoints());
RecordMetrics();
+ double score = GetScore(url);
for (SiteEngagementObserver& observer : observer_list_)
- observer.OnEngagementIncreased(web_contents, url, GetScore(url));
+ observer.OnEngagementIncreased(web_contents, url, score);
}
void SiteEngagementService::HandleUserInput(
@@ -505,8 +521,9 @@ void SiteEngagementService::HandleUserInput(
AddPoints(url, SiteEngagementScore::GetUserInputPoints());
RecordMetrics();
+ double score = GetScore(url);
for (SiteEngagementObserver& observer : observer_list_)
- observer.OnEngagementIncreased(web_contents, url, GetScore(url));
+ observer.OnEngagementIncreased(web_contents, url, score);
}
void SiteEngagementService::SendLevelChangeToHelpers(
« no previous file with comments | « chrome/browser/engagement/site_engagement_service.h ('k') | chrome/browser/engagement/site_engagement_service_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698