Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2376)

Unified Diff: chrome/browser/engagement/site_engagement_observer.h

Issue 2748103011: Grant origins engagement for having interactions on their notifications. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_observer.h
diff --git a/chrome/browser/engagement/site_engagement_observer.h b/chrome/browser/engagement/site_engagement_observer.h
index c3644bf46813cd15104dce45d595aac2421e97b2..50440bb77f5d744d74d3c85038ccb62f5d3f9304 100644
--- a/chrome/browser/engagement/site_engagement_observer.h
+++ b/chrome/browser/engagement/site_engagement_observer.h
@@ -19,9 +19,10 @@ class SiteEngagementObserver {
public:
// Called when the engagement for |url| loaded in |web_contents| increases to
// |score|. |is_hidden| is true if the engagement occurred when |web_contents|
- // was hidden (e.g. in the background).
- // This method may be run on user input, so observers *must not* perform any
- // expensive tasks here.
+ // was hidden (e.g. in the background). This method may be run on user input,
+ // so observers *must not* perform any expensive tasks here. |web_contents|
+ // may be null if the engagement has increased when |url| is not in a tab,
+ // e.g. from a notification interaction.
virtual void OnEngagementIncreased(content::WebContents* web_contents,
const GURL& url,
double score) {}

Powered by Google App Engine
This is Rietveld 408576698