Grant origins engagement for having interactions on their notifications.

chrome/browser/engagement/site_engagement_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/engagement/site_engagement_service.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <utility>
@@ skipping 457 matching lines @@
   if (!ShouldRecordEngagement(url))
     return;
 
   SiteEngagementMetrics::RecordEngagement(
       is_hidden ? SiteEngagementMetrics::ENGAGEMENT_MEDIA_HIDDEN
                 : SiteEngagementMetrics::ENGAGEMENT_MEDIA_VISIBLE);
   AddPoints(url, is_hidden ? SiteEngagementScore::GetHiddenMediaPoints()
                            : SiteEngagementScore::GetVisibleMediaPoints());
 
   RecordMetrics();
+  double score = GetScore(url);
   for (SiteEngagementObserver& observer : observer_list_)
-    observer.OnEngagementIncreased(web_contents, url, GetScore(url));
+    observer.OnEngagementIncreased(web_contents, url, score);
 }
 
 void SiteEngagementService::HandleNavigation(content::WebContents* web_contents,
                                              ui::PageTransition transition) {
   const GURL& url = web_contents->GetLastCommittedURL();
   if (!IsEngagementNavigation(transition) || !ShouldRecordEngagement(url))
     return;
 
   SiteEngagementMetrics::RecordEngagement(
       SiteEngagementMetrics::ENGAGEMENT_NAVIGATION);
   AddPoints(url, SiteEngagementScore::GetNavigationPoints());
 
   RecordMetrics();
+  double score = GetScore(url);
   for (SiteEngagementObserver& observer : observer_list_)
-    observer.OnEngagementIncreased(web_contents, url, GetScore(url));
+    observer.OnEngagementIncreased(web_contents, url, score);
 }
 
 void SiteEngagementService::HandleUserInput(
     content::WebContents* web_contents,
     SiteEngagementMetrics::EngagementType type) {
   const GURL& url = web_contents->GetLastCommittedURL();
   if (!ShouldRecordEngagement(url))
     return;
 
   SiteEngagementMetrics::RecordEngagement(type);
   AddPoints(url, SiteEngagementScore::GetUserInputPoints());
 
   RecordMetrics();
+  double score = GetScore(url);
   for (SiteEngagementObserver& observer : observer_list_)
-    observer.OnEngagementIncreased(web_contents, url, GetScore(url));
+    observer.OnEngagementIncreased(web_contents, url, score);
+}
+
+void SiteEngagementService::HandleNotificationInteraction(const GURL& url) {
+  if (!ShouldRecordEngagement(url))
+    return;
+
+  SiteEngagementMetrics::RecordEngagement(
+      SiteEngagementMetrics::ENGAGEMENT_NOTIFICATION_INTERACTION);
+  AddPoints(url, SiteEngagementScore::GetNotificationInteractionPoints());
+
+  RecordMetrics();
+  double score = GetScore(url);
+  for (SiteEngagementObserver& observer : observer_list_)
+    observer.OnEngagementIncreased(nullptr, url, score);

[Peter Beverloo, 2017/03/16 12:24:14]

nit: I'd annotate the `nullptr` with /* web_contents */

[dominickn, 2017/03/16 23:25:03]

Done.

 }
 
 void SiteEngagementService::SendLevelChangeToHelpers(
     const GURL& url,
     blink::mojom::EngagementLevel level) {
   for (SiteEngagementService::Helper* helper : helpers_)
     helper->OnEngagementLevelChanged(url, level);
 }
 
 bool SiteEngagementService::IsLastEngagementStale() const {
@@ skipping 128 matching lines @@
     if (!engagement_score.last_shortcut_launch_time().is_null() &&
         engagement_score.last_shortcut_launch_time() > last_visit) {
       engagement_score.set_last_shortcut_launch_time(last_visit);
     }
 
     engagement_score.Commit();
   }
 
   SetLastEngagementTime(now);
 }