third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md - Issue 2748103002: [wrapper-tracing] Redesign dispatching on non-inheriting cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md

Issue 2748103002: [wrapper-tracing] Redesign dispatching on non-inheriting cases (Closed)

Patch Set: Addressed comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h ('k') | third_party/WebKit/Source/core/dom/ElementRareData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md

diff --git a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md

index 3547ce013edc62397eac423fde5a547ce3f18c21..4908ec22f11a85c3006a454dcff23273312a63a9 100644

--- a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md

+++ b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md

@@ -257,7 +257,8 @@ difference that these classes need to inherit from ``TraceWrapperBase``.

In the case we cannot afford inheriting from ``TraceWrapperBase``, which will

add a vtable pointer for tracing wrappers, use

-``DECLARE_TRACE_WRAPPERS_WITHOUT_BASE`` to declare a traceWrappers method.

+``DEFINE_TRAIT_FOR_TRACE_WRAPPERS(ClassName)`` after defining

+``ClassName`` to define the proper tracing specializations.

## Explicit write barriers