third_party/WebKit/Source/modules/payments/PaymentRequest.h - Issue 2748093003: PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.h

Issue 2748093003: PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate. (Closed)

Patch Set: PD Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/payments/content/payment_request.mojom ('K') | « third_party/WebKit/Source/modules/payments/PaymentDetailsUpdate.idl ('k') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.h b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

index b0162f85f45a8940a478e8cc2693dccf0ec09466..715936b98647742612db8a1b87120cd31675386d 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

@@ -13,7 +13,8 @@

#include "core/events/EventTarget.h"

#include "modules/ModulesExport.h"

#include "modules/payments/PaymentCompleter.h"

-#include "modules/payments/PaymentDetails.h"

+#include "modules/payments/PaymentDetailsInit.h"

please use gerrit instead 2017/03/21 13:42:21 Please forward declare this instead of including i

zino 2017/03/22 16:43:45 Done.

+#include "modules/payments/PaymentDetailsUpdate.h"

please use gerrit instead 2017/03/21 13:42:21 Please do not include this here. It's not used.

zino 2017/03/22 16:43:45 Done.

#include "modules/payments/PaymentMethodData.h"

#include "modules/payments/PaymentOptions.h"

#include "modules/payments/PaymentUpdater.h"

@@ -48,11 +49,11 @@ class MODULES_EXPORT PaymentRequest final

public:

static PaymentRequest* create(ExecutionContext*,

const HeapVector<PaymentMethodData>&,

- const PaymentDetails&,

+ const PaymentDetailsInit&,

ExceptionState&);

static PaymentRequest* create(ExecutionContext*,

const HeapVector<PaymentMethodData>&,

- const PaymentDetails&,

+ const PaymentDetailsInit&,

const PaymentOptions&,

ExceptionState&);

@@ -91,7 +92,7 @@ class MODULES_EXPORT PaymentRequest final

private:

PaymentRequest(ExecutionContext*,

const HeapVector<PaymentMethodData>&,

- const PaymentDetails&,

+ const PaymentDetailsInit&,

const PaymentOptions&,

ExceptionState&);