PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate.

third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentTestHelper.h"
 
 #include "bindings/core/v8/ScriptState.h"
 #include "core/dom/Document.h"
 #include "modules/payments/PaymentCurrencyAmount.h"
 #include "modules/payments/PaymentMethodData.h"
@@ skipping 37 matching lines @@
     original.setAmount(itemAmount);
 
   if (data == PaymentTestDataLabel) {
     if (modificationType == PaymentTestOverwriteValue)
       original.setLabel(valueToUse);
   } else {
     original.setLabel("Label");
   }
 }
 
+void buildPaymentDetailsBaseInternal(

[please use gerrit instead, 2017/03/21 13:42:21]

No need to use the "Internal" suffix. The "Base" word in the name sufficiently
distinguishes this function from its peers and describes its purpose well.
Please remove the "Internal" suffix.

[zino, 2017/03/22 16:43:45]

Done.

+    PaymentDetailsBase* details,

[please use gerrit instead, 2017/03/21 13:42:21]

The output parameter should be the last one.

[zino, 2017/03/22 16:43:45]

Done.

+    PaymentTestDetailToChange detail,
+    PaymentTestDataToChange data,
+    PaymentTestModificationType modificationType,
+    const String& valueToUse) {
+  PaymentItem item;
+  if (detail == PaymentTestDetailItem)
+    item = buildPaymentItemForTest(data, modificationType, valueToUse);
+  else
+    item = buildPaymentItemForTest();
+
+  PaymentShippingOption shippingOption;
+  if (detail == PaymentTestDetailShippingOption) {
+    shippingOption =
+        buildShippingOptionForTest(data, modificationType, valueToUse);
+  } else {
+    shippingOption = buildShippingOptionForTest();
+  }
+
+  PaymentDetailsModifier modifier;
+  if (detail == PaymentTestDetailModifierTotal ||
+      detail == PaymentTestDetailModifierItem) {
+    modifier = buildPaymentDetailsModifierForTest(detail, data,
+                                                  modificationType, valueToUse);
+  } else {
+    modifier = buildPaymentDetailsModifierForTest();
+  }
+
+  details->setDisplayItems(HeapVector<PaymentItem>(1, item));
+  details->setShippingOptions(
+      HeapVector<PaymentShippingOption>(1, shippingOption));
+  details->setModifiers(HeapVector<PaymentDetailsModifier>(1, modifier));
+}
+
 }  // namespace
 
 PaymentItem buildPaymentItemForTest(
     PaymentTestDataToChange data,
     PaymentTestModificationType modificationType,
     const String& valueToUse) {
   DCHECK_NE(data, PaymentTestDataId);
   PaymentItem item;
   setValues(item, data, modificationType, valueToUse);
   return item;
@@ skipping 31 matching lines @@
   else
     item = buildPaymentItemForTest();
 
   PaymentDetailsModifier modifier;
   modifier.setSupportedMethods(Vector<String>(1, "foo"));
   modifier.setTotal(total);
   modifier.setAdditionalDisplayItems(HeapVector<PaymentItem>(1, item));
   return modifier;
 }
 
-PaymentDetails buildPaymentDetailsForTest(
+PaymentDetailsInit buildPaymentDetailsInitForTest(
     PaymentTestDetailToChange detail,
     PaymentTestDataToChange data,
     PaymentTestModificationType modificationType,
     const String& valueToUse) {
-  PaymentItem total;
-  if (detail == PaymentTestDetailTotal)
-    total = buildPaymentItemForTest(data, modificationType, valueToUse);
-  else
-    total = buildPaymentItemForTest();
+  PaymentDetailsInit details;
+  buildPaymentDetailsBaseInternal(&details, detail, data, modificationType,
+                                  valueToUse);
 
-  PaymentItem item;
-  if (detail == PaymentTestDetailItem)
-    item = buildPaymentItemForTest(data, modificationType, valueToUse);
-  else
-    item = buildPaymentItemForTest();
+  if (detail == PaymentTestDetailTotal) {
+    details.setTotal(
+        buildPaymentItemForTest(data, modificationType, valueToUse));
+  } else {
+    details.setTotal(buildPaymentItemForTest());
+  }
 
-  PaymentShippingOption shippingOption;
-  if (detail == PaymentTestDetailShippingOption)
-    shippingOption =
-        buildShippingOptionForTest(data, modificationType, valueToUse);
-  else
-    shippingOption = buildShippingOptionForTest();
+  return details;
+}
 
-  PaymentDetailsModifier modifier;
-  if (detail == PaymentTestDetailModifierTotal ||
-      detail == PaymentTestDetailModifierItem)
-    modifier = buildPaymentDetailsModifierForTest(detail, data,
-                                                  modificationType, valueToUse);
-  else
-    modifier = buildPaymentDetailsModifierForTest();
+PaymentDetailsUpdate buildPaymentDetailsUpdateForTest(
+    PaymentTestDetailToChange detail,
+    PaymentTestDataToChange data,
+    PaymentTestModificationType modificationType,
+    const String& valueToUse) {
+  PaymentDetailsUpdate details;
+  buildPaymentDetailsBaseInternal(&details, detail, data, modificationType,
+                                  valueToUse);
 
-  PaymentDetails result;
-  result.setTotal(total);
-  result.setDisplayItems(HeapVector<PaymentItem>(1, item));
-  result.setShippingOptions(
-      HeapVector<PaymentShippingOption>(1, shippingOption));
-  result.setModifiers(HeapVector<PaymentDetailsModifier>(1, modifier));
+  if (detail == PaymentTestDetailTotal) {
+    details.setTotal(
+        buildPaymentItemForTest(data, modificationType, valueToUse));
+  } else {
+    details.setTotal(buildPaymentItemForTest());
+  }
 
   if (detail == PaymentTestDetailError)
-    result.setError(valueToUse);
+    details.setError(valueToUse);
 
-  return result;
+  return details;
 }
 
-PaymentDetails buildPaymentDetailsErrorMsgForTest(const String& valueToUse) {
-  return buildPaymentDetailsForTest(PaymentTestDetailError, PaymentTestDataNone,
-                                    PaymentTestOverwriteValue, valueToUse);
+PaymentDetailsUpdate buildPaymentDetailsErrorMsgForTest(
+    const String& valueToUse) {
+  return buildPaymentDetailsUpdateForTest(
+      PaymentTestDetailError, PaymentTestDataNone, PaymentTestOverwriteValue,
+      valueToUse);
 }
 
 HeapVector<PaymentMethodData> buildPaymentMethodDataForTest() {
   HeapVector<PaymentMethodData> methodData(1, PaymentMethodData());
   methodData[0].setSupportedMethods(Vector<String>(1, "foo"));
   return methodData;
 }
 
 payments::mojom::blink::PaymentResponsePtr buildPaymentResponseForTest() {
   payments::mojom::blink::PaymentResponsePtr result =
@@ skipping 55 matching lines @@
   ON_CALL(*this, call(testing::_))
       .WillByDefault(
           testing::DoAll(SaveValueIn(m_value), testing::ReturnArg<0>()));
 }
 
 v8::Local<v8::Function> PaymentRequestMockFunctionScope::MockFunction::bind() {
   return bindToV8Function();
 }
 
 }  // namespace blink