Tighten up subpackage_relationships_test.dart

Tighten up subpackage_relationships_test.dart

This CL adds checks to ensure that the assertions in
subpackage_relationships_test.dart aren't too generous.  For example,
if a subpackage is allowed to import analyzer, we now check that it
actually does import analyzer.

R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/ecb5abbd36511736bb9c3890d6895f62234e622e

[Paul Berry, 2017-03-16 15:58:47]

paulberry@google.com changed reviewers:
+ ahe@google.com, danrubel@google.com

[danrubel, 2017-03-16 16:19:41]

LGTM

[Paul Berry, 2017-03-16 18:34:12]

Description was changed from

==========
Tighten up subpackage_relationships_test.dart

This CL adds checks to ensure that the assertions in
subpackage_relationships_test.dart aren't too generous.  For example,
if a subpackage is allowed to import analyzer, we now check that it
actually does import analyzer.
==========

to

==========
Tighten up subpackage_relationships_test.dart

This CL adds checks to ensure that the assertions in
subpackage_relationships_test.dart aren't too generous.  For example,
if a subpackage is allowed to import analyzer, we now check that it
actually does import analyzer.

R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ecb5abbd36511736bb9c3890d6895f62234e622e
==========

[Paul Berry, 2017-03-16 18:34:13]

Committed patchset #1 (id:1) manually as
ecb5abbd36511736bb9c3890d6895f62234e622e (presubmit successful).

[ahe, 2017-03-17 11:30:52]

lgtm

Nice