Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: milo/appengine/swarming/html_data.go

Issue 2748073006: Milo Refactor: Remove theme support (Closed)
Patch Set: Fix builder.html pointer Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/swarming/html_data.go
diff --git a/milo/appengine/swarming/html_data.go b/milo/appengine/swarming/html_data.go
index 6230e543c12d086c31b6f270099d019d8325bc89..741fdc3898600571468bea61bb4c02fce04c6e5e 100644
--- a/milo/appengine/swarming/html_data.go
+++ b/milo/appengine/swarming/html_data.go
@@ -26,7 +26,7 @@ import (
"github.com/luci/luci-go/logdog/api/logpb"
"github.com/luci/luci-go/logdog/client/coordinator"
"github.com/luci/luci-go/milo/api/resp"
- "github.com/luci/luci-go/milo/appengine/settings"
+ "github.com/luci/luci-go/milo/appengine/common"
"github.com/luci/luci-go/server/templates"
)
@@ -147,17 +147,9 @@ func (svc debugSwarmingService) getTaskOutput(c context.Context, taskID string)
return svc.tc.getSwarmingOutput(), nil
}
-// TestableLog is a subclass of Log that interfaces with TestableHandler and
-// includes sample test data.
-type TestableLog struct{ Log }
-
-// TestableBuild is a subclass of Build that interfaces with TestableHandler and
-// includes sample test data.
-type TestableBuild struct{ Build }
-
-// TestData returns sample test data.
-func (l TestableLog) TestData() []settings.TestBundle {
- return []settings.TestBundle{
+// LogTestData returns sample test data for log pages.
+func LogTestData() []common.TestBundle {
+ return []common.TestBundle{
{
Description: "Basic log",
Data: templates.Args{
@@ -235,8 +227,8 @@ func datagramGetResponse(project, prefix string, msg proto.Message) *logdog.GetR
}
}
-// TestData returns sample test data.
-func (b TestableBuild) TestData() []settings.TestBundle {
+// BuildTestData returns sample test data for swarming build pages.
+func BuildTestData() []common.TestBundle {
basic := resp.MiloBuild{
Summary: resp.BuildComponent{
Label: "Test swarming build",
@@ -246,7 +238,7 @@ func (b TestableBuild) TestData() []settings.TestBundle {
Duration: time.Second,
},
}
- results := []settings.TestBundle{
+ results := []common.TestBundle{
{
Description: "Basic successful build",
Data: templates.Args{"Build": basic},
@@ -266,7 +258,7 @@ func (b TestableBuild) TestData() []settings.TestBundle {
if err != nil {
panic(fmt.Errorf("Error while processing %s: %s", tc.name, err))
}
- results = append(results, settings.TestBundle{
+ results = append(results, common.TestBundle{
Description: tc.name,
Data: templates.Args{"Build": build},
})

Powered by Google App Engine
This is Rietveld 408576698