Milo Refactor: Remove theme support

milo/appengine/buildbot/html.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "fmt"
         "net/http"
         "os"
         "strconv"
 
         "github.com/julienschmidt/httprouter"
         "golang.org/x/net/context"
 
         "github.com/luci/luci-go/milo/appengine/settings"
         "github.com/luci/luci-go/milo/common/miloerror"
         "github.com/luci/luci-go/server/templates"
 )
 
-// Build is the container struct for methods related to buildbot build pages.
-type Build struct{}
-
-// Builder is the container struct for methods related to buildbot builder pages.
-type Builder struct{}
-
-// GetTemplateName returns the template name for build pages.
-func (b Build) GetTemplateName(t settings.Theme) string {
-        return "build.html"
-}
-
-// Render Render the buildbot build page.
-func (b Build) Render(c context.Context, r *http.Request, p httprouter.Params) (*templates.Args, error) {
+// BuildHandler Render the buildbot build page.

[nodir, 2017/03/16 17:42:51]

renders?

[hinoka, 2017/03/17 20:00:21]

Now it does

+func BuildHandler(c context.Context, r *http.Request, p httprouter.Params) (*templates.Args, error) {
         master := p.ByName("master")
         if master == "" {
                 return nil, &miloerror.Error{
                         Message: "No master",
                         Code:    http.StatusBadRequest,
                 }
         }
         builder := p.ByName("builder")
         if builder == "" {
                 return nil, &miloerror.Error{
@@ skipping 19 matching lines @@
         result, err := build(c, master, builder, num)
         if err != nil {
                 return nil, err
         }
 
         // Render into the template
         fmt.Fprintf(os.Stderr, "Result: %#v\n\n", result)
         args := &templates.Args{
                 "Build": result,
         }
         return args, nil

[nodir, 2017/03/16 17:42:51]

without templates, I don't see why not render template right here. This is what
other luci-go apps do, e.g.
https://cs.chromium.org/chromium/infra/go/src/github.com/luci/luci-go/schedul...

[hinoka, 2017/03/17 20:00:21]

Done.

 }
 
-// GetTemplateName returns the template name for builder pages.
-func (b Builder) GetTemplateName(t settings.Theme) string {
-        return "builder.html"
-}
-
-// Render renders the buildbot builder page.
+// BuilderHandler renders the buildbot builder page.
 // Note: The builder html template contains self links to "?limit=123", which could
 // potentially override any other request parameters set.
-func (b Builder) Render(c context.Context, r *http.Request, p httprouter.Params) (*templates.Args, error) {
+func BuilderHandler(c context.Context, r *http.Request, p httprouter.Params) (*templates.Args, error) {
         master := p.ByName("master")
         if master == "" {
                 return nil, &miloerror.Error{
                         Message: "No master specified",
                         Code:    http.StatusBadRequest,
                 }
         }
         builder := p.ByName("builder")
         if builder == "" {
                 return nil, &miloerror.Error{
@@ skipping 13 matching lines @@
         if err != nil {
                 return nil, err
         }
 
         // Render into the template
         args := &templates.Args{
                 "Builder": result,
         }
         return args, nil
 }