Milo Refactor: Remove theme support

milo/appengine/buildbot/master.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "bytes"
         "compress/gzip"
         "encoding/json"
         "fmt"
         "sort"
         "time"
 
         ds "github.com/luci/gae/service/datastore"
         "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/milo/api/resp"
-        "github.com/luci/luci-go/milo/appengine/settings"
+        "github.com/luci/luci-go/milo/appengine/common"
         "github.com/luci/luci-go/server/auth"
         "github.com/luci/luci-go/server/auth/identity"
 
         "golang.org/x/net/context"
 )
 
 func decodeMasterEntry(
         c context.Context, entry *buildbotMasterEntry, master *buildbotMaster) error {
 
         reader, err := gzip.NewReader(bytes.NewReader(entry.Data))
@@ skipping 21 matching lines @@
                 if cu.Identity == identity.AnonymousIdentity {
                         return errNotAuth
                 }
                 return errMasterNotFound
         case err != nil:
                 return err
         }
 
         // Do the ACL check if the entry is internal.
         if internal {
-                allowed, err := settings.IsAllowedInternal(c)
+                allowed, err := common.IsAllowedInternal(c)
                 if err != nil {
                         return err
                 }
                 if !allowed {
                         if cu.Identity == identity.AnonymousIdentity {
                                 return errNotAuth
                         }
                         return errMasterNotFound
                 }
         }
@@ skipping 38 matching lines @@
         if err != nil {
                 return nil, err
         }
 
         // Add each builder from each master entry into the result.
         // TODO(hinoka): FanInOut this?
         for _, entry := range entries {
                 if entry.Internal {
                         // Bypass the master if it's an internal master and the user is not
                         // part of the buildbot-private project.
-                        allowed, err := settings.IsAllowedInternal(c)
+                        allowed, err := common.IsAllowedInternal(c)
                         if err != nil {
                                 logging.WithError(err).Errorf(c, "Could not process master %s", entry.Name)
                                 return nil, err
                         }
                         if !allowed {
                                 continue
                         }
                 }
                 master := &buildbotMaster{}
                 err = decodeMasterEntry(c, entry, master)
@@ skipping 13 matching lines @@
                                 Label: bn,
                                 // Go templates escapes this for us, and also
                                 // slashes are not allowed in builder names.
                                 URL: fmt.Sprintf("/buildbot/%s/%s", entry.Name, bn),
                         })
                 }
                 result.BuilderGroups = append(result.BuilderGroups, ml)
         }
         return result, nil
 }