Milo Refactor: Remove theme support

milo/appengine/buildbot/build.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "encoding/json"
+        "errors"
         "fmt"
         "io/ioutil"
-        "net/http"
         "path/filepath"
         "regexp"
         "sort"
         "strings"
         "time"
 
+        "golang.org/x/net/context"
+
+        "github.com/luci/gae/service/datastore"
         "github.com/luci/luci-go/common/data/stringset"
         "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/milo/api/resp"
-        "github.com/luci/luci-go/milo/common/miloerror"
-
-        ds "github.com/luci/gae/service/datastore"
-
-        "golang.org/x/net/context"
 )
 
-var errBuildNotFound = miloerror.Error{
-        Message: "Build not found",
-        Code:    http.StatusNotFound,
-}
+var errBuildNotFound = errors.New("Build not found")

[nodir, 2017/03/20 19:11:36]

error messages in Go should start with a non-capital letter (because they are
often combined like ("higher-level reason blah blah: %s", err))

I've noticed that this is systematic, so not in this CL

[hinoka, 2017/03/20 19:16:31]

Acknowledged.

 
 // getBuild fetches a buildbot build from the datastore and checks ACLs.
 // The return code matches the master responses.
 func getBuild(c context.Context, master, builder string, buildNum int) (*buildbotBuild, error) {
         result := &buildbotBuild{
                 Master:      master,
                 Buildername: builder,
                 Number:      buildNum,
         }
 
-        err := ds.Get(c, result)
+        err := datastore.Get(c, result)
         err = checkAccess(c, err, result.Internal)
         if err == errMasterNotFound {
                 err = errBuildNotFound
         }
         return result, err
 }
 
 // result2Status translates a buildbot result integer into a resp.Status.
 func result2Status(s *int) (status resp.Status) {
         if s == nil {
@@ skipping 476 matching lines @@
 
         // TODO(hinoka): Do all fields concurrently.
         return &resp.MiloBuild{
                 SourceStamp:   sourcestamp(c, b),
                 Summary:       summary(c, b),
                 Components:    components(b),
                 PropertyGroup: properties(b),
                 Blame:         blame(b),
         }, nil
 }