Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 2748073002: Revert "VM: Simplify lowering of is-tests." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm.cc
diff --git a/runtime/vm/flow_graph_compiler_arm.cc b/runtime/vm/flow_graph_compiler_arm.cc
index 46028f977c9270c3d12128fdb9f4c30c093cf258..6b81354e1b615d90b86c2be6d7d5ec12893390f3 100644
--- a/runtime/vm/flow_graph_compiler_arm.cc
+++ b/runtime/vm/flow_graph_compiler_arm.cc
@@ -556,6 +556,7 @@ RawSubtypeTestCache* FlowGraphCompiler::GenerateInlineInstanceof(
void FlowGraphCompiler::GenerateInstanceOf(TokenPosition token_pos,
intptr_t deopt_id,
const AbstractType& type,
+ bool negate_result,
LocationSummary* locs) {
ASSERT(type.IsFinalized() && !type.IsMalformed() && !type.IsMalbounded());
ASSERT(!type.IsObjectType() && !type.IsDynamicType());
@@ -599,15 +600,23 @@ void FlowGraphCompiler::GenerateInstanceOf(TokenPosition token_pos,
// Pop the parameters supplied to the runtime entry. The result of the
// instanceof runtime call will be left as the result of the operation.
__ Drop(4);
- __ Pop(R0);
+ if (negate_result) {
+ __ Pop(R1);
+ __ LoadObject(R0, Bool::True());
+ __ cmp(R1, Operand(R0));
+ __ b(&done, NE);
+ __ LoadObject(R0, Bool::False());
+ } else {
+ __ Pop(R0);
+ }
__ b(&done);
}
__ Bind(&is_not_instance);
- __ LoadObject(R0, Bool::Get(false));
+ __ LoadObject(R0, Bool::Get(negate_result));
__ b(&done);
__ Bind(&is_instance);
- __ LoadObject(R0, Bool::Get(true));
+ __ LoadObject(R0, Bool::Get(!negate_result));
__ Bind(&done);
// Remove instantiator type arguments (R1).
__ Drop(1);
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698