Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: runtime/vm/constants_dbc.h

Issue 2748073002: Revert "VM: Simplify lowering of is-tests." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/constant_propagator.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/constants_dbc.h
diff --git a/runtime/vm/constants_dbc.h b/runtime/vm/constants_dbc.h
index 3bad2d470ae0ce05d36e78e4f2e88fcb19447c2e..49d2910932fec5d6db547d400bf1158cb8c9349a 100644
--- a/runtime/vm/constants_dbc.h
+++ b/runtime/vm/constants_dbc.h
@@ -531,10 +531,11 @@ namespace dart {
//
// Instantiate type arguments PP[D] with instantiator SP[0].
//
-// - InstanceOf
+// - InstanceOf A
//
-// Test if instance SP[-3] with type arguments SP[-2] is a subtype of SP[-1]
-// using SubtypeTestCache SP[0], with result placed at top of stack.
+// Test if instance SP[-3] with type arguments SP[-2] is (A = 0) or is not
+// (A = 1) a subtype of SP[-1] using SubtypeTestCache SP[0], with result
+// placed at top of stack.
//
// - AssertAssignable A, D
//
@@ -808,7 +809,7 @@ namespace dart {
V(MoveSpecial, A_D, reg, num, ___) \
V(InstantiateType, D, lit, ___, ___) \
V(InstantiateTypeArgumentsTOS, A_D, num, lit, ___) \
- V(InstanceOf, 0, ___, ___, ___) \
+ V(InstanceOf, A, num, ___, ___) \
V(BadTypeError, 0, ___, ___, ___) \
V(AssertAssignable, A_D, num, lit, ___) \
V(AssertBoolean, A, num, ___, ___) \
« no previous file with comments | « runtime/vm/constant_propagator.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698