Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: runtime/vm/kernel_to_il.cc

Issue 2748063003: Reland "VM: Simplify lowering of is-tests."" (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | runtime/vm/simulator_dbc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_to_il.cc
diff --git a/runtime/vm/kernel_to_il.cc b/runtime/vm/kernel_to_il.cc
index e817840567c9ea8c9600bd56c5488da07098fe54..969bccb21ef7120b2b829b83d4b87d807fb4619a 100644
--- a/runtime/vm/kernel_to_il.cc
+++ b/runtime/vm/kernel_to_il.cc
@@ -5027,13 +5027,10 @@ void FlowGraphBuilder::VisitIsExpression(IsExpression* node) {
instructions += Constant(type);
instructions += PushArgument(); // Type.
- instructions += Constant(Bool::False());
- instructions += PushArgument(); // Negate?.
-
instructions +=
InstanceCall(node->position(),
dart::Library::PrivateCoreLibName(Symbols::_instanceOf()),
- Token::kIS, 4);
+ Token::kIS, 3);
}
fragment_ = instructions;
@@ -6123,12 +6120,10 @@ void FlowGraphBuilder::VisitTryCatch(class TryCatch* node) {
catch_body += PushArgument(); // type arguments
catch_body += Constant(*type_guard);
catch_body += PushArgument(); // guard type
- catch_body += Constant(Object::bool_false());
- catch_body += PushArgument(); // negate
catch_body += InstanceCall(
TokenPosition::kNoSource,
dart::Library::PrivateCoreLibName(Symbols::_instanceOf()),
- Token::kIS, 4);
+ Token::kIS, 3);
TargetEntryInstr* catch_entry;
TargetEntryInstr* next_catch_entry;
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | runtime/vm/simulator_dbc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698