|
|
Reland "VM: Simplify lowering of is-tests.""
This reverts commit d44fec08b06198341a2110a54d2b9c8fb131def9.
Remove special-cases for known types (int, String, num, double, Smi). The generic
lowering into an instance call (_simpleInstanceOf) works just fine for these predefined
types.
Also, remove parameter for negated is-tests. Instead insert explicit negation when.
building the flow graph.
Diff to original CL:
* Correct number of arguments in invocation of _instanceOf in kernel_to_il.cc.
R=vegorov@google.com
TBR=vegorov@google.com
Committed: https://github.com/dart-lang/sdk/commit/71cb54714b6969f945b566fdb44a087ca6767acc
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+65 lines, -301 lines) |
Patch |
 |
M |
runtime/lib/object.cc
|
View
|
|
3 chunks |
+2 lines, -62 lines |
0 comments
|
Download
|
|
M |
runtime/lib/object_patch.dart
|
View
|
|
2 chunks |
+1 line, -7 lines |
0 comments
|
Download
|
|
M |
runtime/vm/aot_optimizer.cc
|
View
|
|
5 chunks |
+13 lines, -45 lines |
0 comments
|
Download
|
|
M |
runtime/vm/bootstrap_natives.h
|
View
|
|
1 chunk |
+1 line, -6 lines |
0 comments
|
Download
|
|
M |
runtime/vm/constant_propagator.cc
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
runtime/vm/constants_dbc.h
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_builder.cc
|
View
|
|
2 chunks |
+6 lines, -38 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler_arm.cc
|
View
|
|
2 chunks |
+3 lines, -12 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler_arm64.cc
|
View
|
|
2 chunks |
+3 lines, -12 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler_ia32.cc
|
View
|
|
2 chunks |
+3 lines, -12 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler_mips.cc
|
View
|
|
2 chunks |
+3 lines, -10 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler_x64.cc
|
View
|
|
2 chunks |
+3 lines, -12 lines |
0 comments
|
Download
|
|
M |
runtime/vm/il_printer.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intermediate_language.h
|
View
|
|
3 chunks |
+1 line, -7 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intermediate_language_arm.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intermediate_language_arm64.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intermediate_language_dbc.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
runtime/vm/intermediate_language_ia32.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intermediate_language_mips.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intermediate_language_x64.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/jit_optimizer.cc
|
View
|
|
4 chunks |
+10 lines, -40 lines |
0 comments
|
Download
|
|
M |
runtime/vm/kernel_to_il.cc
|
View
|
|
2 chunks |
+2 lines, -7 lines |
0 comments
|
Download
|
|
M |
runtime/vm/simulator_dbc.cc
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
runtime/vm/symbols.h
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
Total messages: 4 (1 generated)
|
Chromium Code Reviews
Issue
2748063003:
Reland "VM: Simplify lowering of is-tests."" (Closed)
