Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: google_apis/drive/drive_api_parser_unittest.cc

Issue 2748053005: Parse TeamDrive resource inside ChangeList. (Closed)
Patch Set: Default the type field to UNKNOWN as it's not causing new test failures. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/drive/drive_api_parser.cc ('k') | google_apis/test/data/drive/changelist.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/drive/drive_api_parser_unittest.cc
diff --git a/google_apis/drive/drive_api_parser_unittest.cc b/google_apis/drive/drive_api_parser_unittest.cc
index 77579bc2b68fcf5fd642b0190409d0f2f083aa2a..b1d241a639ac297bf4773a548969bf76f9e99dad 100644
--- a/google_apis/drive/drive_api_parser_unittest.cc
+++ b/google_apis/drive/drive_api_parser_unittest.cc
@@ -252,10 +252,11 @@ TEST(DriveAPIParserTest, ChangeListParser) {
changelist->next_link().spec());
EXPECT_EQ(13664, changelist->largest_change_id());
- ASSERT_EQ(4U, changelist->items().size());
+ ASSERT_EQ(5U, changelist->items().size());
const ChangeResource& change1 = *changelist->items()[0];
EXPECT_EQ(8421, change1.change_id());
+ EXPECT_EQ(ChangeResource::FILE, change1.type());
EXPECT_FALSE(change1.is_deleted());
EXPECT_EQ("1Pc8jzfU1ErbN_eucMMqdqzY3eBm0v8sxXm_1CtLxABC", change1.file_id());
EXPECT_EQ(change1.file_id(), change1.file()->file_id());
@@ -264,6 +265,7 @@ TEST(DriveAPIParserTest, ChangeListParser) {
const ChangeResource& change2 = *changelist->items()[1];
EXPECT_EQ(8424, change2.change_id());
+ EXPECT_EQ(ChangeResource::FILE, change2.type());
EXPECT_FALSE(change2.is_deleted());
EXPECT_EQ("0B4v7G8yEYAWHUmRrU2lMS2hLABC", change2.file_id());
EXPECT_EQ(change2.file_id(), change2.file()->file_id());
@@ -272,6 +274,7 @@ TEST(DriveAPIParserTest, ChangeListParser) {
const ChangeResource& change3 = *changelist->items()[2];
EXPECT_EQ(8429, change3.change_id());
+ EXPECT_EQ(ChangeResource::FILE, change3.type());
EXPECT_FALSE(change3.is_deleted());
EXPECT_EQ("0B4v7G8yEYAWHYW1OcExsUVZLABC", change3.file_id());
EXPECT_EQ(change3.file_id(), change3.file()->file_id());
@@ -281,12 +284,26 @@ TEST(DriveAPIParserTest, ChangeListParser) {
// Deleted entry.
const ChangeResource& change4 = *changelist->items()[3];
EXPECT_EQ(8430, change4.change_id());
+ EXPECT_EQ(ChangeResource::FILE, change4.type());
EXPECT_EQ("ABCv7G8yEYAWHc3Y5X0hMSkJYXYZ", change4.file_id());
EXPECT_TRUE(change4.is_deleted());
base::Time modification_time;
ASSERT_TRUE(util::GetTimeFromString("2012-07-27T12:34:56.789Z",
&modification_time));
EXPECT_EQ(modification_time, change4.modification_date());
+
+ // Team Drive entry.
+ const ChangeResource& change5 = *changelist->items()[4];
+ EXPECT_EQ(8431, change5.change_id());
+ EXPECT_EQ(ChangeResource::TEAM_DRIVE, change5.type());
+ EXPECT_EQ("id-of-team-drive-test-data", change5.team_drive()->id());
+ EXPECT_EQ("id-of-team-drive-test-data", change5.team_drive_id());
+ EXPECT_FALSE(change5.is_deleted());
+ ASSERT_TRUE(
+ util::GetTimeFromString("2017-07-27T12:34:56.789Z", &modification_time));
+ EXPECT_EQ(modification_time, change5.modification_date());
+ // capabilities resource inside team_drive should be parsed
+ EXPECT_TRUE(change5.team_drive()->capabilities().can_share());
}
TEST(DriveAPIParserTest, HasKind) {
« no previous file with comments | « google_apis/drive/drive_api_parser.cc ('k') | google_apis/test/data/drive/changelist.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698