Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 274803005: Tentatively revert 268949 "Add browser_test for extension app API with missi..." (Closed)

Created:
6 years, 7 months ago by marja
Modified:
6 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews
Visibility:
Public.

Description

Tentatively revert 268949 "Add browser_test for extension app API with missi..." It's suspected for breaking other browser tests. For more information, see the failing win_chromium_rel try jobs in the code review! > Add browser_test for extension app API with missing schema > > This is a simplified version of api_test/stubs. It touches all the parts > of each chrome.foo.bar.baz API path and ensures they are defined. This > catches cases where a developer adding an API to _api_features.json but > did not provide a schema for them. > > BUG=369318 > TEST=added browser_tests ExtensionApiTest.StubsApp > R=kalman@chromium.org > > Review URL: https://codereview.chromium.org/264923009 TBR=jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -139 lines) Patch
M trunk/src/chrome/browser/extensions/stubs_apitest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/_permission_features.json View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/stubs_app/background.js View 1 chunk +0 lines, -79 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/stubs_app/manifest.json View 1 chunk +0 lines, -45 lines 0 comments Download
M trunk/src/extensions/common/api/_permission_features.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
marja
6 years, 7 months ago (2014-05-08 10:14:35 UTC) #1
marja
Committed patchset #1 manually as r269046 (tree was closed).
6 years, 7 months ago (2014-05-08 10:14:43 UTC) #2
marja
This CL might not have been the problem, but I'm keeping this reverted for now. ...
6 years, 7 months ago (2014-05-08 12:55:04 UTC) #3
James Cook
On 2014/05/08 12:55:04, marja wrote: > This CL might not have been the problem, but ...
6 years, 7 months ago (2014-05-08 16:01:43 UTC) #4
marja
Yeah, the theory where this commit could've caused something was paranoid. (It was related to ...
6 years, 7 months ago (2014-05-08 16:03:32 UTC) #5
James Cook
On 2014/05/08 16:03:32, marja wrote: > Yeah, the theory where this commit could've caused something ...
6 years, 7 months ago (2014-05-08 16:05:03 UTC) #6
marja
6 years, 7 months ago (2014-05-09 07:41:16 UTC) #7
Message was sent while issue was closed.
... and it turned out to be this patch after all!

The world is weird and the most paranoid theories turn out to be correct...

Powered by Google App Engine
This is Rietveld 408576698