Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 274803003: Password bubble: Fix size of "Password deleted" and "Undo" UI. (Closed)

Created:
6 years, 7 months ago by Mike West
Modified:
6 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, tfarina, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

Password bubble: Fix size of "Password deleted" and "Undo" UI. The "undo" interface should use the same sized text as the rest of the interface. Currently it's using the default text size, this CL pushes it a bit smaller to match the mocks. BUG=261628 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/views/passwords/manage_password_item_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mike West
Another tiny fix. Mind taking a look, Vaclav? -mike
6 years, 7 months ago (2014-05-08 07:58:16 UTC) #1
vabr (Chromium)
I did not see the before/after and the mocks this time, but switching to the ...
6 years, 7 months ago (2014-05-08 09:19:22 UTC) #2
Mike West
On 2014/05/08 09:19:22, vabr (Chromium) wrote: > I did not see the before/after and the ...
6 years, 7 months ago (2014-05-08 09:53:00 UTC) #3
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 7 months ago (2014-05-08 09:53:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/274803003/1
6 years, 7 months ago (2014-05-08 09:56:00 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 00:35:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 02:26:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/13991)
6 years, 7 months ago (2014-05-09 02:26:30 UTC) #8
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 7 months ago (2014-05-09 04:43:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/274803003/1
6 years, 7 months ago (2014-05-09 04:48:41 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 14:43:07 UTC) #11
Message was sent while issue was closed.
Change committed as 269291

Powered by Google App Engine
This is Rietveld 408576698