Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/Target.js

Issue 2748023006: [DevTools] Make ConsoleModel not inherit from SDKModel (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/Target.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/Target.js b/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
index 174c9c9d7fe26065b7f508c53ba815ec0205bea1..955544732e771c4792a40629374ea36e003e0e25 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
@@ -142,8 +142,10 @@ SDK.Target = class extends Protocol.TargetBase {
model(modelClass) {
if (!this._modelByConstructor.get(modelClass)) {
var capabilities = SDK.SDKModel._capabilitiesByModelClass.get(modelClass);
- if (capabilities === undefined)
+ if (capabilities === undefined) {
+ console.error(new Error().stack);
caseq 2017/03/15 21:32:01 Is this a stray change? Let's at least have some r
dgozman 2017/03/15 23:08:13 Stray change, thanks! Removed.
throw 'Model class is not registered';
+ }
if ((this._capabilitiesMask & capabilities) === capabilities) {
var model = new modelClass(this);
this._modelByConstructor.set(modelClass, model);

Powered by Google App Engine
This is Rietveld 408576698