Sign extend correctly in disassembler

Sign extend correctly in disassembler

R=vegorov@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/4c05acd59b08c44df1c1d2f91ab32b548c5d3e56

[erikcorry, 2017-03-14 12:34:08]

Example diff:

         ;; Inlined [_GrowableList@0150898.add ->
_GrowableList@0150898._grow@0150898 -> _List@0150898._List@0150898.]
-0xf6dc676c    83c1fe                 add ecx,0xfe
+0xf6df676c    83c1fe                 add ecx,-0x2
         ;; CheckArrayBound:18(v61, v267)

[Vyacheslav Egorov (Google), 2017-03-15 08:03:13]

lgtm

[erikcorry, 2017-03-15 08:20:07]

Description was changed from

==========
Sign extend correctly in disassembler

R=vegorov@google.com
BUG=
==========

to

==========
Sign extend correctly in disassembler

R=vegorov@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/4c05acd59b08c44df1c1d2f91ab32b548c5d3e56
==========

[erikcorry, 2017-03-15 08:20:09]

Committed patchset #1 (id:1) manually as
4c05acd59b08c44df1c1d2f91ab32b548c5d3e56 (presubmit successful).

[sra1, 2017-03-15 17:09:54]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-03-15 17:09:54]

Thanks!

https://codereview.chromium.org/2748023003/diff/1/runtime/vm/disassembler_x64.cc
File runtime/vm/disassembler_x64.cc (right):

https://codereview.chromium.org/2748023003/diff/1/runtime/vm/disassembler_x64...
runtime/vm/disassembler_x64.cc:536: if ((value >= 0) && (value <= 9)) {
It is nice that 1 prints as "1" and not "0x1"
Perhaps do the same for -1, i.e. "-1" and not "-0x1".

I'd like to see cleaner single digit numbers in x86 too.