Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps.html

Issue 2748023002: getInstalledRelatedApps: Change internal url fields to URL type. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps.html
diff --git a/third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps.html b/third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps.html
index 66fedf26de334107207b4cd3d1ddc8acd9f5cf25..9d4b70fd7a634e6c025cb4acde2b01fefd944687 100644
--- a/third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps.html
+++ b/third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps.html
@@ -7,12 +7,13 @@
<script>
installedapp_test((t, mock) => {
+ let itunesUrl = mock.makeUrl('https://itunes.apple.com/');
// The expected input to the Mojo method FilterInstalledRelatedApps is the
// list of related_applications from this page's manifest. The mock service
// returns the empty list, implying that none are installed.
mock.pushExpectedCall(
[{platform: 'play', url: null, id: 'com.test'},
- {platform: 'itunes', url: 'https://itunes.apple.com/', id: null}],
+ {platform: 'itunes', url: itunesUrl, id: null}],
[]);
return navigator.getInstalledRelatedApps().then(result => {
assert_array_relatedapplication_equals(result, []);
@@ -20,13 +21,14 @@ installedapp_test((t, mock) => {
}, 'getInstalledRelatedApps with related apps, none installed');
installedapp_test((t, mock) => {
+ let itunesUrl = mock.makeUrl('https://itunes.apple.com/');
// The expected input to the Mojo method FilterInstalledRelatedApps is the
// list of related_applications from this page's manifest. The mock service
// returns just the 'play' entry. Expect that result to be returned by
// getInstalledRelatedApps.
mock.pushExpectedCall(
[{platform: 'play', url: null, id: 'com.test'},
- {platform: 'itunes', url: 'https://itunes.apple.com/', id: null}],
+ {platform: 'itunes', url: itunesUrl, id: null}],
[{platform: 'play', url: null, id: 'com.test'}]);
// TODO(mgiuca): The |url| field should be omitted from the result, not ''.
return navigator.getInstalledRelatedApps().then(result => {
@@ -36,15 +38,16 @@ installedapp_test((t, mock) => {
}, 'getInstalledRelatedApps with related and installed apps (no url)');
installedapp_test((t, mock) => {
+ let itunesUrl = mock.makeUrl('https://itunes.apple.com/');
// The expected input to the Mojo method FilterInstalledRelatedApps is the
// list of related_applications from this page's manifest. The mock service
// returns both entries. Expect that result to be returned by
// getInstalledRelatedApps.
mock.pushExpectedCall(
[{platform: 'play', url: null, id: 'com.test'},
- {platform: 'itunes', url: 'https://itunes.apple.com/', id: null}],
+ {platform: 'itunes', url: itunesUrl, id: null}],
[{platform: 'play', url: null, id: 'com.test'},
- {platform: 'itunes', url: 'https://itunes.apple.com/', id: null}]);
+ {platform: 'itunes', url: itunesUrl, id: null}]);
// TODO(mgiuca): The null fields should be omitted from the result, not ''.
return navigator.getInstalledRelatedApps().then(result => {
assert_array_relatedapplication_equals(

Powered by Google App Engine
This is Rietveld 408576698