Issue 2748023002: getInstalledRelatedApps: Change internal url fields to URL type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2748023002: getInstalledRelatedApps: Change internal url fields to URL type. (Closed)

Created:
3 years, 9 months ago by Matt Giuca

Modified:
3 years, 3 months ago

Reviewers:

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, haraken, dglazkov+blink, darin-cc_chromium.org, blink-reviews, darin (slow to review), blink-reviews-api_chromium.org, chrome-apps-syd-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

getInstalledRelatedApps: Change internal url fields to URL type. Changes: - WebRelatedApplication's url field from WebString to WebURL. - (Mojo) RelatedApplication's url field from string to url.mojom.Url. Updates layout tests. BUG=587623

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -16 lines)			Patch
M	content/renderer/installedapp/related_apps_fetcher.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps.html	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/installedapp/resources/installedapp-test-helper.js	View	3 chunks	+16 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	third_party/WebKit/public/platform/modules/installedapp/WebRelatedApplication.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	third_party/WebKit/public/platform/modules/installedapp/related_application.mojom	View	1 chunk	+3 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2671683002 Patch 180001

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Message was sent while issue was closed.

Migrated to Gerrit: https://crrev.com/c/637049

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages