third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js - Issue 2747893005: [Devtools] Changed ViewportDataGrid to use DataGrid for dom operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 2747893005: [Devtools] Changed ViewportDataGrid to use DataGrid for dom operations

Patch Set: better viewportdatagrid Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

index 8f5c0b859620e1bd89e8dd247dd1f0d3d0ab9182..5b94b4b5eda0bdb94cd3ce771d54985f5ba882a3 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

@@ -617,7 +617,7 @@ Profiler.HeapSnapshotView = class extends UI.SimpleView {

var runtimeModel = target ? target.model(SDK.RuntimeModel) : null;

if (!row || !span || !target || !runtimeModel)

return null;

- var node = row[DataGrid.DataGrid._dataGridNodeSymbol];

+ var node = row._dataGridNode;

var objectPopoverHelper;

return {

box: span.boxInWindow(),

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js ('k') | no next file » | no next file with comments »