third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-expandable-attached-to-dom.js - Issue 2747893005: [Devtools] Changed ViewportDataGrid to use DataGrid for dom operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-expandable-attached-to-dom.js

Issue 2747893005: [Devtools] Changed ViewportDataGrid to use DataGrid for dom operations

Patch Set: better viewportdatagrid Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-attached-to-dom-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-preserve-selection-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-expandable-attached-to-dom.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-expandable-attached-to-dom.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-expandable-attached-to-dom.js

index 851472da9d93501f2987ae6190dfa4a4c10e9551..78dee70b967bbbf6c92db87240972e7b67da7e23 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-expandable-attached-to-dom.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/viewport-datagrid-items-expandable-attached-to-dom.js

@@ -91,7 +91,7 @@ function test() {

var element = node.existingElement();

if (!element)

continue;

- if (node.attachedToDOM() && div.contains(element)) {

+ if (div.contains(element)) {

var attributes = [];

if (node.hasChildren())

attributes.push("has children");