Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 2747893005: [Devtools] Changed ViewportDataGrid to use DataGrid for dom operations
Patch Set: better viewportdatagrid Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 * @param {!Event} event 610 * @param {!Event} event
611 * @return {?UI.PopoverRequest} 611 * @return {?UI.PopoverRequest}
612 */ 612 */
613 _getPopoverRequest(event) { 613 _getPopoverRequest(event) {
614 var span = event.target.enclosingNodeOrSelfWithNodeName('span'); 614 var span = event.target.enclosingNodeOrSelfWithNodeName('span');
615 var row = event.target.enclosingNodeOrSelfWithNodeName('tr'); 615 var row = event.target.enclosingNodeOrSelfWithNodeName('tr');
616 var target = this._profile.target(); 616 var target = this._profile.target();
617 var runtimeModel = target ? target.model(SDK.RuntimeModel) : null; 617 var runtimeModel = target ? target.model(SDK.RuntimeModel) : null;
618 if (!row || !span || !target || !runtimeModel) 618 if (!row || !span || !target || !runtimeModel)
619 return null; 619 return null;
620 var node = row[DataGrid.DataGrid._dataGridNodeSymbol]; 620 var node = row._dataGridNode;
621 var objectPopoverHelper; 621 var objectPopoverHelper;
622 return { 622 return {
623 box: span.boxInWindow(), 623 box: span.boxInWindow(),
624 show: async popover => { 624 show: async popover => {
625 var remoteObject = await node.queryObjectContent(target, 'popover'); 625 var remoteObject = await node.queryObjectContent(target, 'popover');
626 if (!remoteObject) 626 if (!remoteObject)
627 return false; 627 return false;
628 objectPopoverHelper = await ObjectUI.ObjectPopoverHelper.buildObjectPopo ver(remoteObject, popover); 628 objectPopoverHelper = await ObjectUI.ObjectPopoverHelper.buildObjectPopo ver(remoteObject, popover);
629 if (!objectPopoverHelper) { 629 if (!objectPopoverHelper) {
630 runtimeModel.releaseObjectGroup('popover'); 630 runtimeModel.releaseObjectGroup('popover');
(...skipping 1482 matching lines...) Expand 10 before | Expand all | Expand 10 after
2113 var name = frameDiv.createChild('div'); 2113 var name = frameDiv.createChild('div');
2114 name.textContent = UI.beautifyFunctionName(frame.functionName); 2114 name.textContent = UI.beautifyFunctionName(frame.functionName);
2115 if (frame.scriptId) { 2115 if (frame.scriptId) {
2116 var urlElement = this._linkifier.linkifyScriptLocation( 2116 var urlElement = this._linkifier.linkifyScriptLocation(
2117 this._target, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1); 2117 this._target, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1);
2118 frameDiv.appendChild(urlElement); 2118 frameDiv.appendChild(urlElement);
2119 } 2119 }
2120 } 2120 }
2121 } 2121 }
2122 }; 2122 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698