Add analysis server integration tests for the search domain.

Add analysis server integration tests for the search domain.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a83e7fd18e79fbff9316c873d12a85eedd9af922

[devoncarew, 2017-03-13 22:17:16]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[devoncarew, 2017-03-13 22:17:17]

This adds integration tests to the analysis server's search domain.

Note that the test for search.findMemberReferences is failing for both the old
and new driver. Can you check that I am using the API correctly?

[scheglov, 2017-03-13 22:43:18]

lgtm

https://codereview.chromium.org/2747893004/diff/20001/pkg/analysis_server/tes...
File
pkg/analysis_server/test/integration/search/find_member_references_test.dart
(right):

https://codereview.chromium.org/2747893004/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/integration/search/find_member_references_test.dart:31:
baz() => bar() * bar();
The reason why it does not work is that we return only unresolved references.

[Brian Wilkerson, 2017-03-13 22:54:36]

lgtm

https://codereview.chromium.org/2747893004/diff/20001/pkg/analysis_server/tes...
File
pkg/analysis_server/test/integration/search/find_element_references_test.dart
(right):

https://codereview.chromium.org/2747893004/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/integration/search/find_element_references_test.dart:69:
expect(searchParams.isLast, true);
nit: 'true' --> 'isTrue'

[devoncarew, 2017-03-13 23:08:48]

Thanks, CL updated.

https://codereview.chromium.org/2747893004/diff/20001/pkg/analysis_server/tes...
File
pkg/analysis_server/test/integration/search/find_element_references_test.dart
(right):

https://codereview.chromium.org/2747893004/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/integration/search/find_element_references_test.dart:69:
expect(searchParams.isLast, true);
On 2017/03/13 22:54:36, Brian Wilkerson wrote:
> nit: 'true' --> 'isTrue'

Done.

https://codereview.chromium.org/2747893004/diff/20001/pkg/analysis_server/tes...
File
pkg/analysis_server/test/integration/search/find_member_references_test.dart
(right):

https://codereview.chromium.org/2747893004/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/integration/search/find_member_references_test.dart:31:
baz() => bar() * bar();
On 2017/03/13 22:43:18, scheglov wrote:
> The reason why it does not work is that we return only unresolved references.

Ah, thanks. Updated to have unresolved references, and to remove the @failing
annotation.

[devoncarew, 2017-03-14 00:06:18]

Description was changed from

==========
Add analysis server integration tests for the search domain.

BUG=
==========

to

==========
Add analysis server integration tests for the search domain.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a83e7fd18e79fbff9316c873d12a85eedd9af922
==========

[devoncarew, 2017-03-14 00:06:19]

Committed patchset #3 (id:40001) manually as
a83e7fd18e79fbff9316c873d12a85eedd9af922 (presubmit successful).