Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js

Issue 2747863007: DevTools: clean up tests to not depend on NetworkProject.addFile method (Closed)
Patch Set: typo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
index 0209cb1797ff2358f35b0ff1b299b876279ed7de..3cce183aeede9146983197fa169959d3c9f9d86b 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
@@ -230,8 +230,17 @@ InspectorTest.addUISourceCode = function(target, breakpointManager, url, doNotSe
if (!doNotAddScript)
InspectorTest.addScript(target, breakpointManager, url);
InspectorTest.addResult(" Adding UISourceCode: " + url);
- var contentProvider = Common.StaticContentProvider.fromString(url, Common.resourceTypes.Script, "");
- var uiSourceCode = InspectorTest.testNetworkProject.addFile(contentProvider, null);
+
+ // Add resource to get UISourceCode.
+ var uiSourceCode = InspectorTest.testWorkspace.uiSourceCodeForURL(url);
+ if (uiSourceCode)
+ uiSourceCode.project().removeFile(url);
+ var resource = new SDK.Resource(target, null, url, url, '', '', Common.resourceTypes.Document, 'text/html', null, null);
+ InspectorTest.testNetworkProject._addResource(resource);
+ uiSourceCode = InspectorTest.testWorkspace.uiSourceCodeForURL(url);
+
+ //var contentProvider = Common.StaticContentProvider.fromString(url, Common.resourceTypes.Script, "");
+ //var uiSourceCode = InspectorTest.testNetworkProject.addFile(contentProvider, null);
InspectorTest.uiSourceCodes[url] = uiSourceCode;
if (!doNotSetSourceMapping) {
breakpointManager._debuggerWorkspaceBinding.setSourceMapping(target.debuggerModel, uiSourceCode, breakpointManager.defaultMapping);

Powered by Google App Engine
This is Rietveld 408576698