Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: runtime/vm/kernel_to_il.cc

Issue 2747813003: [kernel] debugging for in statement (Closed)
Patch Set: Updated binary.md Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_binary.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_to_il.cc
diff --git a/runtime/vm/kernel_to_il.cc b/runtime/vm/kernel_to_il.cc
index e817840567c9ea8c9600bd56c5488da07098fe54..698b930d140b81ec33f8a8c4255ff73cffc93dda 100644
--- a/runtime/vm/kernel_to_il.cc
+++ b/runtime/vm/kernel_to_il.cc
@@ -5600,8 +5600,8 @@ void FlowGraphBuilder::VisitForInStatement(ForInStatement* node) {
const dart::String& iterator_getter = dart::String::ZoneHandle(
Z, dart::Field::GetterSymbol(Symbols::Iterator()));
- instructions +=
- InstanceCall(TokenPosition::kNoSource, iterator_getter, Token::kGET, 1);
+ instructions += InstanceCall(node->iterable()->position(), iterator_getter,
+ Token::kGET, 1);
LocalVariable* iterator = scopes_->iterator_variables[for_in_depth_];
instructions += StoreLocal(TokenPosition::kNoSource, iterator);
instructions += Drop();
@@ -5610,7 +5610,7 @@ void FlowGraphBuilder::VisitForInStatement(ForInStatement* node) {
++loop_depth_;
Fragment condition = LoadLocal(iterator);
condition += PushArgument();
- condition += InstanceCall(TokenPosition::kNoSource, Symbols::MoveNext(),
+ condition += InstanceCall(node->iterable()->position(), Symbols::MoveNext(),
Token::kILLEGAL, 1);
TargetEntryInstr* body_entry;
TargetEntryInstr* loop_exit;
@@ -5622,8 +5622,7 @@ void FlowGraphBuilder::VisitForInStatement(ForInStatement* node) {
body += PushArgument();
const dart::String& current_getter = dart::String::ZoneHandle(
Z, dart::Field::GetterSymbol(Symbols::Current()));
- body +=
- InstanceCall(TokenPosition::kNoSource, current_getter, Token::kGET, 1);
+ body += InstanceCall(node->position(), current_getter, Token::kGET, 1);
body +=
StoreLocal(TokenPosition::kNoSource, LookupVariable(node->variable()));
body += Drop();
« no previous file with comments | « runtime/vm/kernel_binary.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698