Issue 2747813003: [kernel] debugging for in statement

Issue 2747813003: [kernel] debugging for in statement (Closed)

Created:
3 years, 9 months ago by jensj

Modified:
3 years, 9 months ago

Reviewers:
ahe, Kevin Millikin (Google)

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -8 lines)			Patch
M	pkg/front_end/lib/src/fasta/kernel/body_builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/binary.md	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/kernel/lib/binary/ast_from_binary.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/kernel/lib/binary/ast_to_binary.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/kernel.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/kernel_binary.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/vm/kernel_to_il.cc	View		3 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 7 (2 generated)

jensj

Turns out debugging of for in via kernel was rather lacking. This (at least together ...

3 years, 9 months ago (2017-03-14 14:55:00 UTC) #2

Kevin Millikin (Google)

I'd call the offset on the for-in loop something like bodyOffset (body_offset) in the identifier ...

3 years, 9 months ago (2017-03-15 11:04:21 UTC) #4

jensj

Thanks! I've updated the binary.md. As discussed offline, I'll ignore the first part.

3 years, 9 months ago (2017-03-15 12:20:46 UTC) #5

jensj

3 years, 9 months ago (2017-03-15 12:23:08 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5e1ba94af4fd275ead850c279f16bd0597bb68da (presubmit successful).