Have dartdevc support --version.

Have dartdevc support --version.

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/b80390d0f5f7a4635d4e8e2a0bbe0bc80a0fc029

[devoncarew, 2017-03-13 19:44:46]

devoncarew@google.com changed reviewers:
+ danrubel@google.com, vsm@google.com

[devoncarew, 2017-03-13 19:44:47]

Add support for --version to dartdevc.
Some small tweaks to the cli help to be more consistent w/ our other tools.
fix https://github.com/dart-lang/sdk/issues/26561

[vsm, 2017-03-13 19:52:18]

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/command.dart (right):

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/command.dart:112: help: 'Root of source files.
'
Can remove space before quote here and 3 lines above.

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/command.dart:235: 'The Dart Development
Compiler compiles Dart sources into a JavaScript module.\n\n'
nit: line len

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/command.dart:242: String versionPath =
Platform.script.resolve('../../version').toFilePath();
Use package path because windows?

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/pubspec.yaml
File pkg/dev_compiler/pubspec.yaml (right):

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/pubspec.ya...
pkg/dev_compiler/pubspec.yaml:5: name: dev_compiler
Do we need a pubspec?  We rely on the .packages file at the root of the sdk -
does ./tool/presubmit still work?

[devoncarew, 2017-03-13 21:10:15]

updated, ptal

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/command.dart (right):

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/command.dart:112: help: 'Root of source files.
'
On 2017/03/13 19:52:17, vsm wrote:
> Can remove space before quote here and 3 lines above.

I think we want to keep these spaces - these strings are concatenated with the
ones on the following lines.

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/command.dart:235: 'The Dart Development
Compiler compiles Dart sources into a JavaScript module.\n\n'
On 2017/03/13 19:52:17, vsm wrote:
> nit: line len

Done.

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/command.dart:242: String versionPath =
Platform.script.resolve('../../version').toFilePath();
On 2017/03/13 19:52:17, vsm wrote:
> Use package path because windows?

I think this uses uri path separators (platform independent ones).

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/pubspec.yaml
File pkg/dev_compiler/pubspec.yaml (right):

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/pubspec.ya...
pkg/dev_compiler/pubspec.yaml:5: name: dev_compiler
On 2017/03/13 19:52:17, vsm wrote:
> Do we need a pubspec?  We rely on the .packages file at the root of the sdk -
> does ./tool/presubmit still work?

The analyzer et all still uses the .packages file at the root of the repo -
having this pubspec file makes IntelliJ slightly happier, at least in terms of
how it displays the errors in the Dart Analysis view. You still wouldn't run pub
in this directory. Happy to remove this file if you like -

[vsm, 2017-03-13 22:47:35]

lgtm

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/command.dart (right):

https://codereview.chromium.org/2747743003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/command.dart:112: help: 'Root of source files.
'
On 2017/03/13 21:10:15, devoncarew wrote:
> On 2017/03/13 19:52:17, vsm wrote:
> > Can remove space before quote here and 3 lines above.
> 
> I think we want to keep these spaces - these strings are concatenated with the
> ones on the following lines.

Ahh missed that!

[devoncarew, 2017-03-13 23:10:26]

Description was changed from

==========
Have dartdevc support --version.

BUG=
==========

to

==========
Have dartdevc support --version.

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b80390d0f5f7a4635d4e8e2a0bbe0bc80a0fc029
==========

[devoncarew, 2017-03-13 23:10:27]

Committed patchset #2 (id:20001) manually as
b80390d0f5f7a4635d4e8e2a0bbe0bc80a0fc029 (presubmit successful).